<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112907/">http://git.reviewboard.kde.org/r/112907/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you provide a patch with --find-copies-harder?
It makes it much easier to read such patches where there are moves and changes.
Also, why did you change from Qt5::Xml to Qt5Xml?</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 23rd, 2013, 5:42 p.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KEmoticons framework to tier3
Done:
-Adjust the CMakeLists.txt to the new location.
-Substitute kde_add_plugin to add_library.
-Substitute Qt5::Xml to Qt5Xml in target_link_libraries
-Substitute Qt5::Test to Qt5Test in target_link_libraries
TODO:
Modify API to make it more coherent</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(5c52cbe)</span></li>
<li>staging/kemoticons/CMakeLists.txt <span style="color: grey">(0e5d935)</span></li>
<li>staging/kemoticons/KEmoticonsConfig.cmake.in <span style="color: grey">(f394979)</span></li>
<li>staging/kemoticons/autotests/CMakeLists.txt <span style="color: grey">(b7e890c)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input <span style="color: grey">(795d3c7)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output <span style="color: grey">(795d3c7)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input <span style="color: grey">(6ddd0c7)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output <span style="color: grey">(6ddd0c7)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input <span style="color: grey">(2571b16)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output <span style="color: grey">(2571b16)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input <span style="color: grey">(f5d8887)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output <span style="color: grey">(0d94eb9)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input <span style="color: grey">(5b39691)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output <span style="color: grey">(5b39691)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input <span style="color: grey">(379e01a)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output <span style="color: grey">(379e01a)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input <span style="color: grey">(a373402)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output <span style="color: grey">(a373402)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input <span style="color: grey">(538c5b0)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output <span style="color: grey">(538c5b0)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input <span style="color: grey">(a5440d6)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output <span style="color: grey">(1f6d4aa)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input <span style="color: grey">(223ce5b)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output <span style="color: grey">(223ce5b)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input <span style="color: grey">(d685c09)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output <span style="color: grey">(e1b37c9)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input <span style="color: grey">(093690c)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output <span style="color: grey">(093690c)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input <span style="color: grey">(3994bf3)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output <span style="color: grey">(cba121a)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input <span style="color: grey">(2319ced)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output <span style="color: grey">(2319ced)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input <span style="color: grey">(d6e7e6c)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output <span style="color: grey">(d6e7e6c)</span></li>
<li>staging/kemoticons/autotests/kemoticontest.h <span style="color: grey">(c79c193)</span></li>
<li>staging/kemoticons/autotests/kemoticontest.cpp <span style="color: grey">(083a804)</span></li>
<li>staging/kemoticons/src/CMakeLists.txt <span style="color: grey">(7b10087)</span></li>
<li>staging/kemoticons/src/core/CMakeLists.txt <span style="color: grey">(f7fb463)</span></li>
<li>staging/kemoticons/src/core/kemoticons.h <span style="color: grey">(12b8308)</span></li>
<li>staging/kemoticons/src/core/kemoticons.cpp <span style="color: grey">(43dac65)</span></li>
<li>staging/kemoticons/src/core/kemoticonsTheme.desktop <span style="color: grey">(848ef2e)</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.h <span style="color: grey">(85fc7ef)</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.cpp <span style="color: grey">(d04c76e)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.h <span style="color: grey">(b8b25f7)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.cpp <span style="color: grey">(ed3407c)</span></li>
<li>staging/kemoticons/src/providers/CMakeLists.txt <span style="color: grey">(445f721)</span></li>
<li>staging/kemoticons/src/providers/adium/CMakeLists.txt <span style="color: grey">(c94c0be)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.h <span style="color: grey">(039a267)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">(a3aaa0f)</span></li>
<li>staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop <span style="color: grey">(181f16a)</span></li>
<li>staging/kemoticons/src/providers/kde/CMakeLists.txt <span style="color: grey">(e6d4243)</span></li>
<li>staging/kemoticons/src/providers/kde/emoticonstheme_kde.desktop <span style="color: grey">(144ee5c)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.h <span style="color: grey">(8cba6b1)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">(5b5114a)</span></li>
<li>staging/kemoticons/src/providers/pidgin/CMakeLists.txt <span style="color: grey">(44ac2dd)</span></li>
<li>staging/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop <span style="color: grey">(e334d3f)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h <span style="color: grey">(70bafa3)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">(e9f89ee)</span></li>
<li>staging/kemoticons/src/providers/xmpp/CMakeLists.txt <span style="color: grey">(f034de0)</span></li>
<li>staging/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop <span style="color: grey">(a6927e4)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h <span style="color: grey">(0873a63)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">(0dc92ed)</span></li>
<li>staging/kemoticons/tests/CMakeLists.txt <span style="color: grey">(f7ec91f)</span></li>
<li>staging/kemoticons/tests/main.cpp <span style="color: grey">(563d760)</span></li>
<li>tier3/CMakeLists.txt <span style="color: grey">(fb4de8f)</span></li>
<li>tier3/kemoticons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/KEmoticonsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-1.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-1.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-10.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-10.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-2.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-2.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-4.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-4.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-5.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-5.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-6.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-6.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-8.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-8.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-9.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/broken-9.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-1.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-1.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-2.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-2.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-3.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-3.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-4.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-4.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-5.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-5.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-6.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-6.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-7.input <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/emoticon-parser-testcases/working-7.output <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/kemoticontest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/autotests/kemoticontest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/kemoticons.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/kemoticons.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/kemoticonsTheme.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/kemoticonsprovider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/kemoticonsprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/kemoticonstheme.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/kemoticonstheme.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/adium/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/adium/adium_emoticons.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/adium/emoticonstheme_adium.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/kde/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/kde/emoticonstheme_kde.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/kde/kde_emoticons.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/pidgin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/pidgin/pidgin_emoticons.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/xmpp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/xmpp/xmpp_emoticons.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/tests/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112907/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>