<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112840/">http://git.reviewboard.kde.org/r/112840/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 90d8df909ab42b6caeb9dbd5dd0a812b062b998b by Aleix Pol to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 20th, 2013, 3:06 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2013, 3:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After the recent changes we can safely change kde4_add_plugin -> add_library</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, nothing seem to have changed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(65fcf6e)</span></li>
<li>interfaces/kmediaplayer/kfileaudiopreview/CMakeLists.txt <span style="color: grey">(b32b816)</span></li>
<li>kdewidgets/CMakeLists.txt <span style="color: grey">(b75f810)</span></li>
<li>kfile/CMakeLists.txt <span style="color: grey">(0475bf2)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(bbaa4bb)</span></li>
<li>khtml/java/CMakeLists.txt <span style="color: grey">(a9e5abf)</span></li>
<li>khtml/kmultipart/CMakeLists.txt <span style="color: grey">(aa62156)</span></li>
<li>kio/kssl/kcm/CMakeLists.txt <span style="color: grey">(88f4479)</span></li>
<li>kio/misc/kpac/CMakeLists.txt <span style="color: grey">(8753923)</span></li>
<li>kioslave/help/CMakeLists.txt <span style="color: grey">(4a5f6ae)</span></li>
<li>kioslave/http/CMakeLists.txt <span style="color: grey">(faf4b5a)</span></li>
<li>kioslave/http/kcookiejar/CMakeLists.txt <span style="color: grey">(62aa05e)</span></li>
<li>kparts/tests/CMakeLists.txt <span style="color: grey">(0e9b2b2)</span></li>
<li>kross/kjs/CMakeLists.txt <span style="color: grey">(22dec92)</span></li>
<li>kross/modules/CMakeLists.txt <span style="color: grey">(fa5cc10)</span></li>
<li>kross/qts/CMakeLists.txt <span style="color: grey">(d575c6d)</span></li>
<li>staging/kde4support/src/kioslave/metainfo/CMakeLists.txt <span style="color: grey">(c96a3f6)</span></li>
<li>staging/kemoticons/src/providers/adium/CMakeLists.txt <span style="color: grey">(2a937f5)</span></li>
<li>staging/kemoticons/src/providers/kde/CMakeLists.txt <span style="color: grey">(02254f0)</span></li>
<li>staging/kemoticons/src/providers/pidgin/CMakeLists.txt <span style="color: grey">(f98e137)</span></li>
<li>staging/kemoticons/src/providers/xmpp/CMakeLists.txt <span style="color: grey">(54975e2)</span></li>
<li>staging/kio/src/kssld/CMakeLists.txt <span style="color: grey">(e64f491)</span></li>
<li>staging/kio/src/widgets/thumbcreator.h <span style="color: grey">(f18cd84)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112840/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>