<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112823/">http://git.reviewboard.kde.org/r/112823/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good overall, but I found a few minor issues.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112823/diff/1/?file=190534#file190534line269" style="color: black; font-weight: bold; text-decoration: underline;">staging/kiconthemes/src/kiconloader.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">269</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> */</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Missing "@since 5.0"</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112823/diff/1/?file=190534#file190534line270" style="color: black; font-weight: bold; text-decoration: underline;">staging/kiconthemes/src/kiconloader.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">270</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KPixmapSequence</span> <span class="nf">loadPixmapSequence</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">iconName</span><span class="p">,</span> <span class="kt">int</span> <span class="n">size</span> <span class="o">=</span> <span class="n">SizeSmall</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be const</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112823/diff/1/?file=190536#file190536line74" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kwidgetsaddons/src/kpixmapsequence.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">explicit</span> <span class="nf">KPixmapSequence</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n"><span class="hl">iconName</span></span><span class="p">,</span> <span class="kt">int</span> <span class="n">size</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n"><span class="hl">KIconLoader</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">SizeSmall</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">explicit</span> <span class="nf">KPixmapSequence</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n"><span class="hl">fullPath</span></span><span class="p">,</span> <span class="kt">int</span> <span class="n">size</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No need for "explicit" now that the constructor takes two mandatory arguments.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112823/diff/1/?file=190546#file190546line6" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kwidgetsaddons/tests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set</span><span class="p">(</span><span class="s">ANIMATION_FILE</span> <span class="s2">"${CMAKE_CURRENT_SOURCE_DIR}/kpixmap-animation.png"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In KDE4 days programs marked as test had a KDESRCDIR define set which pointed to CMAKE_CURRENT_SOURCE_DIR. If it still exists it would be simpler to use it than to define a config file.</pre>
</div>
<br />
<p>- Aurélien</p>
<br />
<p>On September 19th, 2013, 4:04 p.m. CEST, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aurélien Gâteau.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2013, 4:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG.
As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>knewstuff/src/ui/itemsviewbasedelegate.cpp <span style="color: grey">(4c2733d)</span></li>
<li>knewstuff/src/ui/progressindicator.cpp <span style="color: grey">(1ca9478)</span></li>
<li>staging/kiconthemes/autotests/CMakeLists.txt <span style="color: grey">(1e5899f)</span></li>
<li>staging/kiconthemes/autotests/kiconloader_unittest.cpp <span style="color: grey">(116203c)</span></li>
<li>staging/kiconthemes/src/CMakeLists.txt <span style="color: grey">(0de6456)</span></li>
<li>staging/kiconthemes/src/kiconloader.h <span style="color: grey">(65346df)</span></li>
<li>staging/kiconthemes/src/kiconloader.cpp <span style="color: grey">(36a61a1)</span></li>
<li>staging/kiconthemes/src/kpixmapsequence.h <span style="color: grey">(ef94596)</span></li>
<li>staging/kiconthemes/src/kpixmapsequence.cpp <span style="color: grey">(c5b42e1)</span></li>
<li>staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h <span style="color: grey">(1c64e82)</span></li>
<li>staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp <span style="color: grey">(4632e74)</span></li>
<li>staging/kiconthemes/src/kpixmapsequencewidget.h <span style="color: grey">(c6c7e17)</span></li>
<li>staging/kiconthemes/src/kpixmapsequencewidget.cpp <span style="color: grey">(f7ab00c)</span></li>
<li>staging/kiconthemes/tests/CMakeLists.txt <span style="color: grey">(855d45d)</span></li>
<li>staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h <span style="color: grey">()</span></li>
<li>staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp <span style="color: grey">(e60682c)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(e1d039b)</span></li>
<li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(e4227a2)</span></li>
<li>tier1/kwidgetsaddons/tests/kpixmap-animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112823/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>