<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112823/">http://git.reviewboard.kde.org/r/112823/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch does not apply there (complains about kpixmap-animation.png), but I assume this is a reviewboard glitch, so ship it.</pre>
 <br />









<p>- Aurélien</p>


<br />
<p>On September 19th, 2013, 5:25 p.m. CEST, Àlex Fiestas wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks and Aurélien Gâteau.</div>
<div>By Àlex Fiestas.</div>


<p style="color: grey;"><i>Updated Sept. 19, 2013, 5:25 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG.

As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KDE5PORTING.html <span style="color: grey">(c1dde0a)</span></li>

 <li>knewstuff/src/ui/itemsviewbasedelegate.cpp <span style="color: grey">(4c2733d)</span></li>

 <li>knewstuff/src/ui/progressindicator.cpp <span style="color: grey">(1ca9478)</span></li>

 <li>staging/kiconthemes/autotests/CMakeLists.txt <span style="color: grey">(1e5899f)</span></li>

 <li>staging/kiconthemes/autotests/kiconloader_unittest.cpp <span style="color: grey">(116203c)</span></li>

 <li>staging/kiconthemes/src/CMakeLists.txt <span style="color: grey">(0de6456)</span></li>

 <li>staging/kiconthemes/src/kiconloader.h <span style="color: grey">(65346df)</span></li>

 <li>staging/kiconthemes/src/kiconloader.cpp <span style="color: grey">(36a61a1)</span></li>

 <li>staging/kiconthemes/src/kpixmapsequence.h <span style="color: grey">(ef94596)</span></li>

 <li>staging/kiconthemes/src/kpixmapsequence.cpp <span style="color: grey">(c5b42e1)</span></li>

 <li>staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h <span style="color: grey">(1c64e82)</span></li>

 <li>staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp <span style="color: grey">(4632e74)</span></li>

 <li>staging/kiconthemes/src/kpixmapsequencewidget.h <span style="color: grey">(c6c7e17)</span></li>

 <li>staging/kiconthemes/src/kpixmapsequencewidget.cpp <span style="color: grey">(f7ab00c)</span></li>

 <li>staging/kiconthemes/tests/CMakeLists.txt <span style="color: grey">(855d45d)</span></li>

 <li>staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h <span style="color: grey">()</span></li>

 <li>staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp <span style="color: grey">(e60682c)</span></li>

 <li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(e1d039b)</span></li>

 <li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(e4227a2)</span></li>

 <li>tier1/kwidgetsaddons/tests/kpixmap-animation.png <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112823/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>