<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112797/">http://git.reviewboard.kde.org/r/112797/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 18th, 2013, 5:23 p.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Posting the same here as i just said in your other review request. (I didn't see this one)
Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" that is taking the QCollator route. That way it's easily testable as well.
I think we can all agree on that, right?</pre>
</blockquote>
<p>On September 18th, 2013, 5:26 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">** posting again as well... **
I don't think creating such function would be a good thing because it means using QCollator the wrong way. I much rather prefer working on tools to properly use QCollator, for example by making it possible to sort things with the sort key instead of QCollator::compare which will be the place where we can actually test performance.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">True, but then it can't be used as a 1 on 1 replacement. Since QCollatorSortKey would first have to be generated for every string and stored in the list that is to be sorted (That would be the ItemData struct http://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=841016138c4a67691177ae9d759eae6399adc762&hb=7dde35ccb97ac2958e45fe6b0759901e02d5e5e3&f=dolphin%2Fsrc%2Fkitemviews%2Fkfileitemmodel.h from line 299). But yeah, that does seem like a very nice idea and close to an idea that was floating the kfm-devel list ~1 year ago which also involved adding some "precompiled" sort data in that very same structure to speed up sorting.
Anyway, +1 from me but someone else must give a ship it.</pre>
<br />
<p>- Mark</p>
<br />
<p>On September 18th, 2013, 4:55 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2013, 4:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kcoreaddons/autotests/kstringhandlertest.cpp <span style="color: grey">(93da351)</span></li>
<li>tier1/kcoreaddons/src/lib/text/kstringhandler.h <span style="color: grey">(442b97a)</span></li>
<li>tier1/kcoreaddons/src/lib/text/kstringhandler.cpp <span style="color: grey">(ea3bbf5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112797/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>