<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112583/">http://git.reviewboard.kde.org/r/112583/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me now.</pre>
<br />
<p>- Aurélien</p>
<br />
<p>On September 17th, 2013, 1:45 a.m. CEST, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2013, 1:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KConfigWidgets relies on a private header in KWidgetAddons. This prevents KConfigWidgets building on it's own
By exposing the two of these private members in protected methods, we can solve this problem.
Commit log below:
--------------
change target link libraries to ${lib_LIBRARIES} format
--
Remove inheritance on KSelectionActionPrivate in KRecentFileActions
This is in a different framework so cannot be used when building
standalone.
--
Expose associated comboboxes and toolbuttons in KSelectAction</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kconfigwidgets/src/krecentfilesaction.h <span style="color: grey">(edf77a2)</span></li>
<li>staging/kconfigwidgets/src/krecentfilesaction.cpp <span style="color: grey">(9aa5f8b)</span></li>
<li>staging/kconfigwidgets/src/krecentfilesaction_p.h <span style="color: grey">(8b3cc8f)</span></li>
<li>tier1/kwidgetsaddons/src/kselectaction.h <span style="color: grey">(07afaa9)</span></li>
<li>tier1/kwidgetsaddons/src/kselectaction.cpp <span style="color: grey">(3aa0797)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112583/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>