<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112679/">http://git.reviewboard.kde.org/r/112679/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 96f363e4f7f8b6655df19440e609fd661b96fb6d by Sebastian Kügler to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 14th, 2013, 6:17 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2013, 6:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows search through KPluginInfo::List, additionally to KService::List. Together with the other patches from my set It makes it possible to search through the plugin's (JSON-based) metadata, using our constraint syntax.
It adds a ctor that takes a KPluginInfo::List& and adds the necessary branches to look within either the KService::List or the KPluginInfo::List.
There's one problem I don't know an elegant solution to, will point that out in the diff.
This, and the other patches from this set are also in kdelibs[sebas/pluginlocator]</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Added tests (separate review), all pass
- Ported Plasma::PluginLoader from KServiceTypeTrader to KPluginTrader and tested the querying in a real-world scenario, no regressions spotted
- No regressions in existing tests
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kservice/src/services/ktraderparsetree.cpp <span style="color: grey">(4257e43)</span></li>
<li>staging/kservice/src/services/ktraderparsetree_p.h <span style="color: grey">(7664943)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112679/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>