<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112681/">http://git.reviewboard.kde.org/r/112681/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2013, 7:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Issues addressed, there's one style-thing which I'll keep like it is. Otherwise, all tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests for KPluginTrader.
Under autotests/, there's a new test class which runs a variety of queries using KPluginTrader. There's also a small plugin, which is used to verify correct metadata querying and loading. It's not installed since QPluginLoader conveniently contains the working directory when looking for plugins -> it's found just fine.
Under tests/, there's a test which will query for a variety of other plugins. This one is more geared towards performance testing. When run from make test, it will pass anyway.
Code can also be found in kdelibs[sebas/pluginlocator].</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make test =)
All tests pass on top of my patches.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kservice/autotests/CMakeLists.txt <span style="color: grey">(d341040)</span></li>
<li>staging/kservice/autotests/fakeplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/autotests/fakeplugin.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/autotests/nsaplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/autotests/nsaplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/autotests/pluginlocatortest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/autotests/pluginlocatortest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/tests/CMakeLists.txt <span style="color: grey">(3793aea)</span></li>
<li>staging/kservice/tests/pluginlocator/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/tests/pluginlocator/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/tests/pluginlocator/plugintest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/tests/pluginlocator/plugintest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112681/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>