<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112710/">http://git.reviewboard.kde.org/r/112710/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4cb177ae494e04a250bdcd4088777e42ab275626 by Àlex Fiestas to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 13th, 2013, 11:21 a.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2013, 11:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KIO::NetAccess to kde4support.
I have also added @deprecated to all the functions that did not have with the exception of fish_execute that I'm unsure if we want to provide an alternative for that (since it will always be dependent on a slave...).
Also, I haven't added KDE4SUPPORT_DEPREACTED_EXPORT to all methods, that would add too much noise when compiling other modules... we have to find a better solution to deprecate all kde4support.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/CMakeLists.txt <span style="color: grey">(d44dcc2)</span></li>
<li>kio/kio/netaccess.h <span style="color: grey">(11a4ac9)</span></li>
<li>kio/kio/netaccess.cpp <span style="color: grey">()</span></li>
<li>kio/tests/CMakeLists.txt <span style="color: grey">(1874712)</span></li>
<li>kio/tests/fileundomanagertest.cpp <span style="color: grey">(5f5fb27)</span></li>
<li>kio/tests/jobguitest.cpp <span style="color: grey">(ec65942)</span></li>
<li>kio/tests/jobremotetest.cpp <span style="color: grey">(ce99ff4)</span></li>
<li>kio/tests/kdirmodeltest.cpp <span style="color: grey">(256d32e)</span></li>
<li>kio/tests/netaccesstest.cpp <span style="color: grey">()</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(466c195)</span></li>
<li>staging/kde4support/tests/CMakeLists.txt <span style="color: grey">(2c38f46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112710/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>