<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112583/">http://git.reviewboard.kde.org/r/112583/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 11th, 2013, 4:13 p.m. UTC, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112583/diff/2/?file=188967#file188967line240" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kwidgetsaddons/src/kselectaction.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KSelectAction::setMaxComboViewCount( int n )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">240</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KSelectAction</span><span class="o">::</span><span class="n">addAction</span><span class="p">(</span><span class="n">QAction</span><span class="o">*</span> <span class="n">action</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">240</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KSelectAction</span><span class="o">::</span><span class="n">addAction</span><span class="p">(</span><span class="n">QAction</span><span class="o">*</span> <span class="n">action</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To avoid duplication you could reimplement KSelectAction::addAction(act) as insertAction(0, act)
You might also want to make KSelectAction::addAction() not virtual, so that there is only one way to change the class behavior when actions are added/inserted.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I originally thought about doing that then rejected it assuming QWidget::addAction() would be somehow faster than insertAction() and we shouldn't throw that away.
Now I've looked at Qt code it shows that they just call insertAction(0, action); so it does make sense for us to do the same thing. Will change.</pre>
<br />
<p>- David</p>
<br />
<p>On September 11th, 2013, 2:55 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2013, 2:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KConfigWidgets relies on a private header in KWidgetAddons. This prevents KConfigWidgets building on it's own
By exposing the two of these private members in protected methods, we can solve this problem.
Commit log below:
--------------
change target link libraries to ${lib_LIBRARIES} format
--
Remove inheritance on KSelectionActionPrivate in KRecentFileActions
This is in a different framework so cannot be used when building
standalone.
--
Expose associated comboboxes and toolbuttons in KSelectAction</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kconfigwidgets/src/CMakeLists.txt <span style="color: grey">(dad6bcc140cb4fe56380bd44ea007fe1f06edace)</span></li>
<li>staging/kconfigwidgets/src/krecentfilesaction.h <span style="color: grey">(edf77a24866018134d9c5a200c6e35213742c555)</span></li>
<li>staging/kconfigwidgets/src/krecentfilesaction.cpp <span style="color: grey">(9aa5f8bd83d064402dd6333c7cd89a388d373fe1)</span></li>
<li>staging/kconfigwidgets/src/krecentfilesaction_p.h <span style="color: grey">(8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c)</span></li>
<li>tier1/kwidgetsaddons/src/kselectaction.h <span style="color: grey">(07afaa960d2be4877aeef0ff074d0fd20c7b7f40)</span></li>
<li>tier1/kwidgetsaddons/src/kselectaction.cpp <span style="color: grey">(3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112583/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>