<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112556/">http://git.reviewboard.kde.org/r/112556/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 10th, 2013, 9:06 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is it too late for that? Do we plan to have a proper/final "let's look at what we did" API review after everything has settled?</pre>
<br />
<p>- Christoph</p>
<br />
<p>On September 10th, 2013, 10:45 a.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2013, 10:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the
if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within
kdelibs.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and passes tests when build from kdelibs and standalone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(f0b6bf0)</span></li>
<li>staging/itemviews/CMakeLists.txt <span style="color: grey">(f5c3c8d)</span></li>
<li>staging/itemviews/ItemViewsConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/itemviews/autotests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/itemviews/autotests/klistwidgetsearchlinetest.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorizedview.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorizedview.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorizedview_p.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorydrawer.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kcategorydrawer.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kextendableitemdelegate.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kextendableitemdelegate.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kfilterproxysearchline.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kfilterproxysearchline.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/klistwidgetsearchline.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/klistwidgetsearchline.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/ktreewidgetsearchline.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/ktreewidgetsearchline.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate_p.h <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegatepool.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/src/kwidgetitemdelegatepool_p.h <span style="color: grey">()</span></li>
<li>staging/itemviews/tests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/itemviews/tests/kcategorizedviewtest.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/tests/ktreewidgetsearchlinetest.h <span style="color: grey">()</span></li>
<li>staging/itemviews/tests/ktreewidgetsearchlinetest.cpp <span style="color: grey">()</span></li>
<li>staging/itemviews/tests/kwidgetitemdelegatetest.cpp <span style="color: grey">()</span></li>
<li>tier2/CMakeLists.txt <span style="color: grey">(62faacb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112556/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>