<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112574/">http://git.reviewboard.kde.org/r/112574/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2013, 3:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I renamed knewstuff/knewstuff3 to knewstuff/src and rearranged the TODO files a bit.
Also fixed build issues with code that was #including <knewstuff3/*> when it shouldn't have been.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds and installs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>knewstuff/knewstuff3/TODO <span style="color: grey">(d8905f53ad526350c4a5f89d713f06388cdeb56d)</span></li>
<li>knewstuff/knewstuff3/CMakeLists.txt <span style="color: grey">()</span></li>
<li>knewstuff/TODO.knewstuff2 <span style="color: grey">(PRE-CREATION)</span></li>
<li>knewstuff/TODO <span style="color: grey">(6bd4dc4f263badf2e9a2e75b5becacd3d48d4e52)</span></li>
<li>knewstuff/CMakeLists.txt <span style="color: grey">(a402e82096d25c3b75182202fbb6594c3d22a02f)</span></li>
<li>knewstuff/knewstuff3/attica/atticaprovider.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/attica/atticaprovider.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/CLASSES <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/DESIGN <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/USE-CASES <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/author.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/author.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/cache.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/cache.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/engine.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/engine.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/entryinternal.h <span style="color: grey">(ea88cad9d3d4626e6845f96ca5054b6a9f1f761a)</span></li>
<li>knewstuff/knewstuff3/core/entryinternal.cpp <span style="color: grey">(08f2611950f0faf805e1dd84200fa56ac20c3f7e)</span></li>
<li>knewstuff/knewstuff3/core/installation.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/installation.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/provider.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/provider.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/security.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/security.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/upload.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/upload.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/xmlloader.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/core/xmlloader.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/downloaddialog.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/downloaddialog.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/downloadmanager.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/downloadmanager.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/downloadwidget.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/downloadwidget.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/downloadwidget.ui <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/downloadwidget_p.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/entry.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/entry.cpp <span style="color: grey">(991a3826255b3b6dd45923c3cca5ad4512ed4787)</span></li>
<li>knewstuff/knewstuff3/entry_p.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/knewstuffaction.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/knewstuffaction.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/knewstuffbutton.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/knewstuffbutton.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/staticxml/staticxmlprovider.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/staticxml/staticxmlprovider.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/entrydetailsdialog.h <span style="color: grey">(52733d78f1b727b718bfa3dd9925f7f46d73528a)</span></li>
<li>knewstuff/knewstuff3/ui/entrydetailsdialog.cpp <span style="color: grey">(8d3441f2ad6096df1312a516e29cb17b89d8e024)</span></li>
<li>knewstuff/knewstuff3/ui/imageloader.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/imageloader.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/imagepreviewwidget.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/imagepreviewwidget.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsgridviewdelegate.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsgridviewdelegate.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsmodel.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsmodel.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsview.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsview.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsviewbasedelegate.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsviewbasedelegate.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsviewdelegate.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/itemsviewdelegate.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/progressindicator.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/ui/progressindicator.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/upload/atticahelper.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/upload/atticahelper.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/uploaddialog.h <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/uploaddialog.cpp <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/uploaddialog.ui <span style="color: grey">()</span></li>
<li>knewstuff/knewstuff3/uploaddialog_p.h <span style="color: grey">()</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112574/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>