<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112527/">http://git.reviewboard.kde.org/r/112527/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David</p>
<br />
<p>On September 9th, 2013, 12:05 a.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2013, 12:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clean up KEmoticons framework (prior to splitting)
--Clean up includes
--Turn KEmoticonsProvider abstract and reorganize some code
--Revise documentation
--Use QScopedPointer where useful
--Port away from KIO in KEmoticonsProvider
--Put const where fit
TODO:
--Port away from KServiceTypeTrader. Sebas is working on a way to get
the plugin list without KServiceTypeTrader.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles and test passes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kemoticons/autotests/kemoticontest.cpp <span style="color: grey">(0ca1671d26970998c13022daa839e1aae4907220)</span></li>
<li>staging/kemoticons/src/core/kemoticons.h <span style="color: grey">(57912b550c5e941f751d93c084b37764635e11c7)</span></li>
<li>staging/kemoticons/src/core/kemoticons.cpp <span style="color: grey">(317089ed94179aac2b7e448414df930dcfd0c0dd)</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.h <span style="color: grey">(3f43ca4c8a1fe74ce01a1aac1abdeb84b9da08d2)</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.cpp <span style="color: grey">(1fcad79bd49919058bb21b262b57b7a9bb6ac5c9)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.h <span style="color: grey">(d0e1a899e2f8a89b34e6337848c1aeab7f60ef88)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.cpp <span style="color: grey">(cd385fde6095b2da930de9ec03a501ae3d1ab0f7)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">(f465b64e230639f16ca073ed7ab08a79f04afd4a)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">(7d777b5aa0a869a0009814bb43f84f802444d5d6)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">(65b2c5e979eeccbc98986432962e3ab05f39ca57)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">(2535b71263f468dacc830e7cf92fead5e61528e8)</span></li>
<li>staging/kemoticons/tests/main.cpp <span style="color: grey">(f46265e97243aa776f901120d832368154c5c2ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112527/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>