<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112570/">http://git.reviewboard.kde.org/r/112570/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Anything that had "TEST" should now have ecm_mark_as_test. You missed a few towards the end.
BTW is there a porting guide for kde4_add_executable -> add_executable? People porting the other modules will have the same issue.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112570/diff/1/?file=187694#file187694line29" style="color: black; font-weight: bold; text-decoration: underline;">experimental/kdeclarative/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">test/test.cpp</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_test</span><span class="p">(</span><span class="s">kdeclarative-kdeclarativetest</span> <span class="s">kdeclarativetest</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks like a manual GUI test program, not like a unittest. Try "make test" in this dir, to see the problem :)
-> remove the add_test line.
(TODO for another patch: rename the subdir to tests and move this into its own CMakeLists.txt)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112570/diff/1/?file=187699#file187699line43" style="color: black; font-weight: bold; text-decoration: underline;">kinit/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="err"><span class="hl">kde4_</span>add_executable(kdeinit5</span> <span class="err"><span class="hl">NOGUI</span></span><span class="hl"> </span><span class="err">${kdeinit_SRCS})</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">add_executable</span><span class="p">(</span><span class="s">kdeinit5</span> <span class="o">${</span><span class="nv">kdeinit_SRCS</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move this line out of the if (APPLE), now that it's the same on all platforms.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112570/diff/1/?file=187699#file187699line44" style="color: black; font-weight: bold; text-decoration: underline;">kinit/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">ecm_mark_nongui_executable</span><span class="p">(</span><span class="s">kdeinit5</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This could also be moved out of the if, by using the proper arguments for ecm_mark_nongui_executable, so that it doesn't disable the mac bundle.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112570/diff/1/?file=187699#file187699line84" style="color: black; font-weight: bold; text-decoration: underline;">kinit/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="err"><span class="hl">kde4_</span>add_executable(kshell4</span> <span class="err"><span class="hl">NOGUI</span></span><span class="hl"> </span><span class="err">shell.cpp)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">84</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">add_executable</span><span class="p">(</span><span class="s">kshell4</span> <span class="s">shell.cpp</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why didn't this one get ecm_mark_nongui_executable?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112570/diff/1/?file=187703#file187703line7" style="color: black; font-weight: bold; text-decoration: underline;">kio/tests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="err">kde4_add_unit_test(${_testname}</span> <span class="err">TESTNAME</span> <span class="err">kio-${_testname}</span> <span class="err">${_testname}.cpp)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="err">kde4_add_unit_test(${_testname}</span> <span class="err">TESTNAME</span> <span class="err">kio-${_testname}</span> <span class="err">${_testname}.cpp)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you'll replace all kde4_add_unit_test in another patch? ;)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112570/diff/1/?file=187703#file187703line13" style="color: black; font-weight: bold; text-decoration: underline;">kio/tests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="err"><span class="hl">kde4_</span>add_executable(${_testname}</span> <span class="err"><span class="hl">TEST</span></span><span class="hl"> </span><span class="err">${_testname}.cpp)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">add_executable</span><span class="p">(</span><span class="o">${</span><span class="nv">_testname</span><span class="o">}</span> <span class="o">${</span><span class="nv">_testname</span><span class="o">}</span><span class="s">.cpp</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">missing ecm_mark_as_test</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112570/diff/1/?file=187704#file187704line18" style="color: black; font-weight: bold; text-decoration: underline;">kioslave/http/kcookiejar/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err"><span class="hl">kde4_</span>add_executable(</span> <span class="err">kcookiejar4</span> <span class="err"><span class="hl">NOGUI</span></span><span class="hl"> </span><span class="err"><span class="hl">${kcookiejar_SRCS}</span>)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_executable</span><span class="p">(</span> <span class="s">kcookiejar4</span> <span class="s"><span class="hl">main.cpp</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks wrong to me. All the lines above add stuff to kcookiejar_SRCS. You should keep using that instead of just main.cpp.
I'm surprised this actually compiled...</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On September 6th, 2013, 6:52 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2013, 6:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kde4_add_executable is deprecated. Port all kde4_add_executable uses to add_executable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, although it doesn't change much in linux.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>experimental/kdeclarative/CMakeLists.txt <span style="color: grey">(a7bddfa)</span></li>
<li>interfaces/terminal/example/CMakeLists.txt <span style="color: grey">(e8c3f01)</span></li>
<li>kdesu/CMakeLists.txt <span style="color: grey">(351ad85)</span></li>
<li>kdewidgets/CMakeLists.txt <span style="color: grey">(038da6b)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(124c3eb)</span></li>
<li>kinit/CMakeLists.txt <span style="color: grey">(ff7b7fd)</span></li>
<li>kio/misc/CMakeLists.txt <span style="color: grey">(e2c62d6)</span></li>
<li>kio/misc/kpac/CMakeLists.txt <span style="color: grey">(04ffba1)</span></li>
<li>kio/misc/ksendbugmail/CMakeLists.txt <span style="color: grey">(cbe4bd9)</span></li>
<li>kio/tests/CMakeLists.txt <span style="color: grey">(825ca3c)</span></li>
<li>kioslave/http/kcookiejar/CMakeLists.txt <span style="color: grey">(fcb620e)</span></li>
<li>kjsembed/examples/kjsconsole/CMakeLists.txt <span style="color: grey">(2438323)</span></li>
<li>kjsembed/kjscmd/CMakeLists.txt <span style="color: grey">(f457933)</span></li>
<li>knotify/tests/CMakeLists.txt <span style="color: grey">(bc6f5e0)</span></li>
<li>kparts/tests/CMakeLists.txt <span style="color: grey">(bb8a120)</span></li>
<li>kpty/CMakeLists.txt <span style="color: grey">(2cc2885)</span></li>
<li>kross/console/CMakeLists.txt <span style="color: grey">(58257ca)</span></li>
<li>staging/kde4support/CMakeLists.txt <span style="color: grey">(0445f0a)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(6f4603d)</span></li>
<li>staging/kemoticons/tests/CMakeLists.txt <span style="color: grey">(5e0d46e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112570/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>