<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111938/">http://git.reviewboard.kde.org/r/111938/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 1st, 2013, 5:16 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me.</pre>
</blockquote>
<p>On September 5th, 2013, 6:49 p.m. UTC, <b>Ivan Romanov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me. </pre>
</blockquote>
<p>On September 6th, 2013, 9:30 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Holy... and here I was, thinking I was doing something good by reviewing patches for QCA, for lack of reviewers/maintainers.
Fine, I will definitely stay out of QCA completely, it's not like I ever wanted to be involved with it.
It's all yours now.
When objecting to a patch, you might want to give a more detailed technical argumentation than "I don't agree", BTW.
But I don't care anymore for that argumentation, that's a discussion between you and Alexander.
About notifications: you were in the CC for the request, according to reviewboard. You might want to check which emails reviewboard has for you, or your mail setup.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bad ides was to change default values. Now Gentoo building broken also ... yestarday we was building QCA for Qt5 on Windows and couldn't understand why it was installing to "C:\Program Files\" and had -qt5 suffix.
So Alexander please revert
1. QCA_INSTALL_IN_QT_PREFIX default value
2. QCA_LIB_SUFFIX defalut value
3. QCA_INCLUDE_INSTALL_DIR and QCA_PRIVATE_INCLUDE_INSTALL_DIR in case when QCA_INSTALL_IN_QT_PREFIX == OFF.
Also what for LIB_INSTALL_DIR has different values for Qt4 and Qt5?
When I was writing this rules I want to reach the purposes of:
1. Easy installing when building manually.
2. Good adjustability to satisfy any needs.
David. Thanks for review and thanks for your care Qca.</pre>
<br />
<p>- Ivan</p>
<br />
<p>On September 3rd, 2013, 12:42 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Ivan Romanov.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2013, 12:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use qt5 suffix for files by default when installing a Qt5 version of QCA
This way coinstallation of Qt4 and Qt5 based QCA is possible by default
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and installed.
creating a Qt5 package for openSuSE works fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8cff977)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(037c9ff)</span></li>
<li>src/config-qca.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qca_plugin.cpp <span style="color: grey">(ad810b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111938/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>