<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112536/">http://git.reviewboard.kde.org/r/112536/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before you move kunitconversion, please add the necessary find_dependency() to its Config file so that it's usable standalone. It should be possible to use find_package(KUnitConversion) ... target_link_libraries(someexe KF5::KUnitConversion) without errors.
In a separate patch, obviously.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112536/diff/1/?file=187204#file187204line9" style="color: black; font-weight: bold; text-decoration: underline;">tier2/kunitconversion/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">9</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">find_package</span><span class="p">(</span><span class="s">Qt5</span> <span class="s">5.2</span> <span class="s">REQUIRED</span> <span class="s">NO_MODULE</span> <span class="s">COMPONENTS</span> <span class="s">Xml</span> <span class="s">Network</span> <span class="s">Test</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please do this in a separate patch *before* moving.
When moving a framework, no other changes should be needed/hidden in the move commit.</pre>
</div>
<br />
<p>- Stephen</p>
<br />
<p>On September 5th, 2013, 2:27 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2013, 2:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had to tell it to find Qt specifically, nothing else.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(ae2cbf8)</span></li>
<li>staging/kunitconversion/CMakeLists.txt <span style="color: grey">(1346a00)</span></li>
<li>staging/kunitconversion/KUnitConversionConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/kunitconversion/autotests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kunitconversion/autotests/categorytest.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/autotests/categorytest.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/autotests/convertertest.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/autotests/convertertest.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/autotests/valuetest.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/autotests/valuetest.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/Mainpage.dox <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/Messages.sh <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/acceleration.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/acceleration.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/angle.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/angle.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/area.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/area.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/converter.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/converter.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/currency.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/currency.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/density.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/density.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/energy.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/energy.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/force.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/force.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/frequency.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/frequency.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/fuel_efficiency.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/fuel_efficiency.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/kcurrencycode.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/kcurrencycode.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/length.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/length.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/mass.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/mass.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/power.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/power.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/pressure.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/pressure.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/temperature.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/temperature.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/timeunit.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/timeunit.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/unit.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/unit.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/unitcategory.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/unitcategory.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/value.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/value.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/velocity.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/velocity.cpp <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/volume.h <span style="color: grey">()</span></li>
<li>staging/kunitconversion/src/volume.cpp <span style="color: grey">()</span></li>
<li>tier2/CMakeLists.txt <span style="color: grey">(1f110e8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112536/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>