<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112495/">http://git.reviewboard.kde.org/r/112495/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 4th, 2013, 10:47 a.m. UTC, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112495/diff/2/?file=186875#file186875line12" style="color: black; font-weight: bold; text-decoration: underline;">tier2/kcrash/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">find_package</span><span class="p">(</span><span class="s">Qt5</span> <span class="s">5.2.0</span> <span class="s">REQUIRED</span> <span class="s">NO_MODULE</span> <span class="s">COMPONENTS</span> <span class="s">Widgets</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">8</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">find_package</span><span class="p">(</span><span class="s">Qt5</span> <span class="s">5.2.0</span> <span class="s">REQUIRED</span> <span class="s">NO_MODULE</span> <span class="s">COMPONENTS</span> <span class="s"><span class="hl">Gui</span></span><span class="hl"> </span><span class="s">Widgets</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why was this needed? Widgets already finds Qt5Gui.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't it the other way around (Gui finds Widgets)? It was added because it links to Gui because it needs qwindowdefs.h, which is in Gui.</pre>
<br />
<p>- Martin</p>
<br />
<p>On September 4th, 2013, 10:01 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2013, 10:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes the remove_definitions(..) from cmake, no code changes needed. KCrash however has no tests, I'm not sure how to test it properly (if someone can give me ideas, I'll try writing such tests).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds ok.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(3e4ec3a)</span></li>
<li>staging/kcrash/CMakeLists.txt <span style="color: grey">(ce926ec)</span></li>
<li>staging/kcrash/KCrashConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/kcrash/src/CMakeLists.txt <span style="color: grey">(5dab9be)</span></li>
<li>staging/kcrash/src/config-kcrash.h.cmake <span style="color: grey">()</span></li>
<li>staging/kcrash/src/config-strlcpy.h.cmake <span style="color: grey">()</span></li>
<li>staging/kcrash/src/kcrash.h <span style="color: grey">()</span></li>
<li>staging/kcrash/src/kcrash.cpp <span style="color: grey">()</span></li>
<li>staging/kcrash/src/strlcpy-fake.c <span style="color: grey">()</span></li>
<li>tier2/CMakeLists.txt <span style="color: grey">(bd5ea8c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112495/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>