<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112495/">http://git.reviewboard.kde.org/r/112495/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 16964ce920f96cee53fdfcb380d1a6d48b649832 by Martin Klapetek to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 3rd, 2013, 8:35 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2013, 8:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes the remove_definitions(..) from cmake, no code changes needed. KCrash however has no tests, I'm not sure how to test it properly (if someone can give me ideas, I'll try writing such tests).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds ok.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(3e4ec3a)</span></li>
<li>staging/kcrash/CMakeLists.txt <span style="color: grey">(ce926ec)</span></li>
<li>staging/kcrash/KCrashConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/kcrash/src/CMakeLists.txt <span style="color: grey">(5dab9be)</span></li>
<li>staging/kcrash/src/config-kcrash.h.cmake <span style="color: grey">()</span></li>
<li>staging/kcrash/src/config-strlcpy.h.cmake <span style="color: grey">()</span></li>
<li>staging/kcrash/src/kcrash.h <span style="color: grey">()</span></li>
<li>staging/kcrash/src/kcrash.cpp <span style="color: grey">()</span></li>
<li>staging/kcrash/src/strlcpy-fake.c <span style="color: grey">()</span></li>
<li>tier2/CMakeLists.txt <span style="color: grey">(bd5ea8c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112495/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>