<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112479/">http://git.reviewboard.kde.org/r/112479/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 3rd, 2013, 12:34 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112479/diff/1/?file=186788#file186788line9" style="color: black; font-weight: bold; text-decoration: underline;">staging/kbookmarks/tests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">9</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ecm_mark_as_test</span><span class="p">(</span><span class="o">${</span><span class="nv">kbookmarkdialogtest</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't that only for unittests?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this is wrong kconfigwidgets and ktextwidgets and kcompletion are also wrong.
I've pushed as-is for now, if this is wrong, let me know and I'll check all the modules.</pre>
<br />
<p>- David</p>
<br />
<p>On September 3rd, 2013, 12:10 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2013, 12:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split Bookmarks out of kio folder into own folder in staging.
This is simply a splitting + moving + removing deprecated functions, I am aware it doesn't comply with a lot of other things on the frameworks checklist yet.
It is possible to split kbookmarks into core + gui. Do we want that?
We also need to decide what tier this is aiming for. I think 3 as we use parts of KIO.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles + test runs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/CMakeLists.txt <span style="color: grey">(167f697)</span></li>
<li>kio/bookmarks/kbookmark.h <span style="color: grey">(2d06120)</span></li>
<li>kio/bookmarks/kbookmark.cc <span style="color: grey">(beb82db)</span></li>
<li>kio/bookmarks/kbookmarkdialog.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkdialog.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkdialog_p.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkdombuilder.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkdombuilder.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkexporter.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter_ie.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter_ie.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter_ns.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter_ns.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter_opera.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter_opera.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkimporter_opera_p.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkmanager.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkmanager.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkmanageradaptor.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkmanageradaptor_p.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkmenu.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkmenu.cc <span style="color: grey">()</span></li>
<li>kio/bookmarks/kbookmarkmenu_p.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/konqbookmarkmenu.h <span style="color: grey">()</span></li>
<li>kio/bookmarks/konqbookmarkmenu.cc <span style="color: grey">()</span></li>
<li>kio/tests/CMakeLists.txt <span style="color: grey">(e9e7265)</span></li>
<li>kio/tests/kbookmarkdialogtest.cpp <span style="color: grey">()</span></li>
<li>kio/tests/kbookmarktest.h <span style="color: grey">()</span></li>
<li>kio/tests/kbookmarktest.cpp <span style="color: grey">()</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(1602d95)</span></li>
<li>staging/kbookmarks/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kbookmarks/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kbookmarks/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kbookmarks/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112479/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>