<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112479/">http://git.reviewboard.kde.org/r/112479/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 454c537a44cd06cd739872e40b8b5a7718897864 by David Edmundson to branch frameworks.</pre>
 <br />









<p>- Commit</p>


<br />
<p>On September 3rd, 2013, 12:10 p.m. UTC, David Edmundson wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>


<p style="color: grey;"><i>Updated Sept. 3, 2013, 12:10 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split Bookmarks out of kio folder into own folder in staging.

This is simply a splitting + moving + removing deprecated functions, I am aware it doesn't comply with a lot of other things on the frameworks checklist yet.

It is possible to split kbookmarks into core + gui. Do we want that?

We also need to decide what tier this is aiming for. I think 3 as we use parts of KIO.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles  + test runs.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/CMakeLists.txt <span style="color: grey">(167f697)</span></li>

 <li>kio/bookmarks/kbookmark.h <span style="color: grey">(2d06120)</span></li>

 <li>kio/bookmarks/kbookmark.cc <span style="color: grey">(beb82db)</span></li>

 <li>kio/bookmarks/kbookmarkdialog.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkdialog.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkdialog_p.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkdombuilder.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkdombuilder.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkexporter.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter_ie.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter_ie.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter_ns.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter_ns.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter_opera.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter_opera.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkimporter_opera_p.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkmanager.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkmanager.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkmanageradaptor.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkmanageradaptor_p.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkmenu.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkmenu.cc <span style="color: grey">()</span></li>

 <li>kio/bookmarks/kbookmarkmenu_p.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/konqbookmarkmenu.h <span style="color: grey">()</span></li>

 <li>kio/bookmarks/konqbookmarkmenu.cc <span style="color: grey">()</span></li>

 <li>kio/tests/CMakeLists.txt <span style="color: grey">(e9e7265)</span></li>

 <li>kio/tests/kbookmarkdialogtest.cpp <span style="color: grey">()</span></li>

 <li>kio/tests/kbookmarktest.h <span style="color: grey">()</span></li>

 <li>kio/tests/kbookmarktest.cpp <span style="color: grey">()</span></li>

 <li>staging/CMakeLists.txt <span style="color: grey">(1602d95)</span></li>

 <li>staging/kbookmarks/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>staging/kbookmarks/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>staging/kbookmarks/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>staging/kbookmarks/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112479/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>