<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112485/">http://git.reviewboard.kde.org/r/112485/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Document dependencies, drop KCoreAddons and KIconLoader.
Remove config.h file, figure out whether we're on X11 at runtime instead of at build time. We won't want to have separate kdelibs for X11 and Wayland.
Regarding the KNotifications dependency, I'd suggest to remove it (I would do it myself). At the moment it's generating quite a bit of DBus noise even though it's not being used elsewhere (in my system or Alex's it doesn't make any noise or show anything).
It's used in KHistoryBox and KCompletion. If you want to test it, you can play with KRunner.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds, tests pass</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kcompletion/src/klineedit.cpp <span style="color: grey">(b2b430d)</span></li>
<li>staging/kcompletion/src/config-kcompletion.h.cmake <span style="color: grey">(35b64a2)</span></li>
<li>staging/kcompletion/src/CMakeLists.txt <span style="color: grey">(f08a47d)</span></li>
<li>staging/kcompletion/src/klineedit_p.h <span style="color: grey">(4d3cfbc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112485/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>