<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112401/">http://git.reviewboard.kde.org/r/112401/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 1st, 2013, 10:25 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112401/diff/2/?file=186081#file186081line1293" style="color: black; font-weight: bold; text-decoration: underline;">staging/ki18n/src/klocalizedstring.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1293</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">availableLanguages</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">s</span><span class="o">-></span><span class="n">codeLanguage</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should this insert be outside the if block?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I chose on impulse to have it not ignore the anomalous case where
KLocalizedString::setApplicationDomain was not called at some point earlier.
I.e. if "there is no application" then there are also no available
translations. But I don't have in mind any concrete advantage or
disadvantage of either solution.
</pre>
<br />
<p>- Chusslove</p>
<br />
<p>On September 1st, 2013, 12:22 p.m. UTC, Chusslove Illich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol Gonzalez.</div>
<div>By Chusslove Illich.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2013, 12:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add the static method KLocalizedString::availableApplicationTranslations
that reports the list of language codes for which there exists the
translation catalog for application's domain (as set by
KLocalizedString::setApplicationDomain). This allows client code e.g. to
offer a language switching feature in an application.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit test supplied.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/ki18n/autotests/klocalizedstringtest.cpp <span style="color: grey">(ec3966f)</span></li>
<li>staging/ki18n/src/kcatalog.cpp <span style="color: grey">(183bea5)</span></li>
<li>staging/ki18n/src/kcatalog_p.h <span style="color: grey">(6feb09c)</span></li>
<li>staging/ki18n/src/klocalizedstring.h <span style="color: grey">(eb44075)</span></li>
<li>staging/ki18n/src/klocalizedstring.cpp <span style="color: grey">(eab9216)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112401/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>