<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112461/">http://git.reviewboard.kde.org/r/112461/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, assuming you went through the checklist at http://community.kde.org/Frameworks/Epics/Splitting_kdelibs ("Definition of done").</pre>
<br />
<p>- David</p>
<br />
<p>On September 2nd, 2013, 6:58 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2013, 6:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KGuiAddons into tier1/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All builds and installs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(1602d95)</span></li>
<li>staging/kguiaddons/CMakeLists.txt <span style="color: grey">(6a2b57e)</span></li>
<li>staging/kguiaddons/KGuiAddonsConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/kguiaddons/autotests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kguiaddons/autotests/kcolorutilstest.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/autotests/kcolorutilstest.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/autotests/kiconutilstest.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/autotests/kiconutilstest.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/autotests/kwordwraptest.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kcolorcollection.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kcolorcollection.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kcolormimedata.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kcolormimedata.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kcolorspaces.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kcolorspaces.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kcolorutils.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kcolorutils.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/colors/kguiaddons_colorhelpers_p.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/fonts/kfontutils.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/fonts/kfontutils.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/text/kwordwrap.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/text/kwordwrap.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kiconutils.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kiconutils.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kimagecache.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/klocalimagecacheimpl.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/klocalimagecacheimpl.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kmodifierkeyinfo.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kmodifierkeyinfo.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/lib/util/urlhandler.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/AUTHORS <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/ChangeLog <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/Mainpage.dox <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/README <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/bmp.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/config-kimgio.h.cmake <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/dds.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/dds.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/dds.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/dds.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/eps.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/eps.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/eps.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/eps.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/exr.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/exr.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/exr.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/exr.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/g3r.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/g3r.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/gif.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/gimp.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/hdr.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/hdr.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/hdr.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/ico.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/jp2.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/jp2.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/jp2.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/jp2.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/jpeg.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/mng.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pbm.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pcx.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pcx.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pcx.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pcx.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pgm.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pic.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pic.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pic.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pic.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pic_read.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pic_rw.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pic_write.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/png.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/pnm.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/ppm.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/psd.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/psd.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/psd.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/psd.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/qimageio_plugin.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/ras.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/ras.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/ras.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/ras.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/rgb.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/rgb.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/rgb.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/rgb.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/svg+xml-compressed.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/svg+xml.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/tga.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/tga.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/tga.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/tga.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/tiff.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xbm.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xcf.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xcf.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xcf.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xcf.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xpm.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xv.desktop <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xview.h <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xview.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/src/plugins/xview.json <span style="color: grey">()</span></li>
<li>staging/kguiaddons/tests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kguiaddons/tests/kcolorcollectiontest.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/tests/kmodifierkeyinfotest.cpp <span style="color: grey">()</span></li>
<li>staging/kguiaddons/tests/openurltest.cpp <span style="color: grey">()</span></li>
<li>tier1/CMakeLists.txt <span style="color: grey">(12b7359)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112461/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>