<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112418/">http://git.reviewboard.kde.org/r/112418/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2013, 12:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">replace KSharedPtr with QExplicitlySharedDataPointer</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and tests pass
I guess KSharedPtr can be moved to kde4support after this commit</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dnssd/avahi-servicebrowser.cpp <span style="color: grey">(38d1a0741198405df84a8dca658bb3b9b96fda00)</span></li>
<li>dnssd/remoteservice.h <span style="color: grey">(12d7e5d589ac79a9431290633a47bc67e974d83c)</span></li>
<li>dnssd/servicebase.h <span style="color: grey">(6ae9d20e23baa747e6f9def8d01e474df08822da)</span></li>
<li>kded/kbuildservicefactory.cpp <span style="color: grey">(a19ad9d7e33d78a76a21671f2a73373eb2b89b13)</span></li>
<li>kded/kbuildservicegroupfactory.cpp <span style="color: grey">(035d3fa131e9be1fc34ec24fc1d6ee3f7d85ffa6)</span></li>
<li>kded/kbuildservicetypefactory.cpp <span style="color: grey">(28637ad4ca70496c65b77d341d1bd297e1327c3a)</span></li>
<li>kded/kbuildsycoca.cpp <span style="color: grey">(6e456ec4a2ff3c5ca426edee18e075e9ac33b4f6)</span></li>
<li>kded/vfolder_menu.cpp <span style="color: grey">(5f7878781f1fb972a4d30b43545c093a21b82d77)</span></li>
<li>kio/tests/ksycocatest.cpp <span style="color: grey">(c066b81fd35d3bc481a191cc22ebc9160846e3e8)</span></li>
<li>kparts/tests/openorsavequestion_unittest.cpp <span style="color: grey">(ce97a39be9574258a151335abe0cb282cd30a2b5)</span></li>
<li>kross/core/object.h <span style="color: grey">(455525557532fd2adfe9b9b13646f026a956629d)</span></li>
<li>kutils/kcmoduleinfo.h <span style="color: grey">(742719846ee959a2443e20e3450564e2a7c92df1)</span></li>
<li>kutils/kpluginselector.cpp <span style="color: grey">(5f68aec3a25b8752261ab3edce1c383f427dc271)</span></li>
<li>kutils/ksettings/dialog.cpp <span style="color: grey">(4a48b8e37c495808856ea4ec6808e4233f95427b)</span></li>
<li>staging/kde4support/autotests/kmimetypetest.cpp <span style="color: grey">(2626b62dd0524c19f9e991052e14fd0ebdec7cc8)</span></li>
<li>staging/kde4support/src/kdecore/kmimetype.h <span style="color: grey">(0e9fbaaefb1c8a7a92ac7f9896d75ee532e8d7d5)</span></li>
<li>staging/kde4support/src/kdecore/kmimetype.cpp <span style="color: grey">(d397ba8b233e7da9be381820e8c2eeb4b02f4c83)</span></li>
<li>staging/kde4support/src/kio/kdatatool.cpp <span style="color: grey">(b1ad8857ad4440d4610e87c8b6f903d2609c53ae)</span></li>
<li>staging/kio/src/core/kmountpoint.h <span style="color: grey">(406a252e622d6c51c4f87a37f3ac2359ace7a696)</span></li>
<li>staging/kio/src/widgets/kfileitemactions.cpp <span style="color: grey">(d64bf6567ddef0a004f3eb57089dd3c219a430d8)</span></li>
<li>staging/kio/src/widgets/kopenwithdialog.cpp <span style="color: grey">(ca90b5ac1a5a644e0a5cae1b1847a49a4fd9b7bf)</span></li>
<li>staging/kio/src/widgets/krun.cpp <span style="color: grey">(80ed1a6b42f9eff5cd2e87d2d831ede3a252e565)</span></li>
<li>staging/kservice/autotests/kservicetest.cpp <span style="color: grey">(b4e37abfc076297efde3737209bd816ad666413c)</span></li>
<li>staging/kservice/autotests/ksycocadicttest.cpp <span style="color: grey">(6a265705ad79ad08240c2bb51da0c0a8d4d38ecb)</span></li>
<li>staging/kservice/src/services/kmimetypefactory.h <span style="color: grey">(6cbc0213b954b8a286e59c0aeb425855b04a79a7)</span></li>
<li>staging/kservice/src/services/kmimetypefactory.cpp <span style="color: grey">(1cd1ef07663082a724750cf2c65467235b59eddb)</span></li>
<li>staging/kservice/src/services/kservice.h <span style="color: grey">(55fa2faa2970d8f0e12f8499f172e412c8c74b97)</span></li>
<li>staging/kservice/src/services/kservicefactory.cpp <span style="color: grey">(599a261e90a9cc9e221ce0c88c53c5a6e979cd35)</span></li>
<li>staging/kservice/src/services/kservicegroup.h <span style="color: grey">(89e5ed579c72f2b67e1d492c45acbfb9fc9e86b0)</span></li>
<li>staging/kservice/src/services/kservicegroup.cpp <span style="color: grey">(1b5ab7b4226c148a687e07bb3af3d6de3ac68261)</span></li>
<li>staging/kservice/src/services/kservicegroup_p.h <span style="color: grey">(5f2149798ef139be6d10ae262d2c819720ab4ccf)</span></li>
<li>staging/kservice/src/services/kservicetype.h <span style="color: grey">(2b588ac3f82ff974501217e7223815776c664976)</span></li>
<li>staging/kservice/src/services/kservicetypefactory.cpp <span style="color: grey">(fccb43f372c25e3bb704aeccf5f084c4b6ae388b)</span></li>
<li>staging/kservice/src/services/kservicetypeprofile.cpp <span style="color: grey">(5643558a07a0a15f4a9256d34e2413d81a4e4ae6)</span></li>
<li>staging/kservice/src/services/ktraderparse.cpp <span style="color: grey">(940580bccd46b180cf6504401376a522f4ca0676)</span></li>
<li>staging/kservice/src/services/ktraderparsetree_p.h <span style="color: grey">(ad6066ae7441a50cc2ec9cd95810333537b45fbc)</span></li>
<li>staging/kservice/src/sycoca/ksycocadict.cpp <span style="color: grey">(0599c6ca4934d21ce6a6bcf605063e1719a775c8)</span></li>
<li>staging/kservice/src/sycoca/ksycocaentry.h <span style="color: grey">(a7b2702afe04520bd5035fc69bb95fe8f3269387)</span></li>
<li>staging/kunitconversion/src/kunitconversion/converter.cpp <span style="color: grey">(a433240e97910da19af328727c39a20ce296cb94)</span></li>
<li>staging/kunitconversion/src/kunitconversion/unit.h <span style="color: grey">(731c77baf9c3e73f422b65b3e3003a38efa7e572)</span></li>
<li>tier1/kconfig/src/core/kconfig.cpp <span style="color: grey">(d44c1d21807c1a3e62c4b7410ddd4232cbb828b7)</span></li>
<li>tier1/kconfig/src/core/kconfig_p.h <span style="color: grey">(29ec44e3b4c87e48fc6072426c7398fb275115a8)</span></li>
<li>tier1/kconfig/src/core/kconfigbackend.h <span style="color: grey">(738cd27998a15cc459b0c252442e8fbfd7c5b4de)</span></li>
<li>tier1/kconfig/src/core/kconfigbackend.cpp <span style="color: grey">(c25671ace96b4102115cf2244c5dd79317ff57b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112418/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>