<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112007/">http://git.reviewboard.kde.org/r/112007/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This one can be committed now, can't it?</pre>
<br />
<p>- David</p>
<br />
<p>On August 10th, 2013, 11:12 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2013, 11:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use KDE configured shortcuts for Qt default key bindings
Upgrade our QPlatformTheme to return the keybindings.
If the shortcut exists in KStandardShortcuts and can be configured use that;
otherwise use the default from Qt.
----
Relies on
https://codereview.qt-project.org/#change,62059
A spreadsheet of the bindings between QKeySequence -> KStandardShortcut is here:
http://static.davidedmundson.co.uk/key_bindings.csv
I think some may be valid candidates for later adding to KStandardShortcut, in particular Add Tab.
Not sure on the others. Not everything in QKeySequence::StandardKeys needs to be configurable IMHO.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">None.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h <span style="color: grey">(edac8dba066b6d9981a6bc509b07e1ecdf0dd516)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp <span style="color: grey">(d46b5c850d3c6027e592ad0cc17f4449c4fc1e31)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112007/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>