<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112331/">http://git.reviewboard.kde.org/r/112331/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112331/diff/1/?file=185481#file185481line10" style="color: black; font-weight: bold; text-decoration: underline;">staging/kunitconversion/src/kunitconversion/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">configure_file</span><span class="p">(</span><span class="s">config-kunitconversion.h.cmake</span> <span class="o">${</span><span class="nv">CMAKE_CURRENT_BINARY_DIR</span><span class="o">}</span><span class="s">/config-kunitconversion.h</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also the translation domain is configured in config-kunitconversion.h. This
is used to specialize i18n calls to this domain, that come from subsequent
inclusion of klocalizedstring.h. So either config-kunitconversion.h should
remain, or each file that included it should have in its place
#define TRANSLATION_DOMAIN "libkunitconversion"
</pre>
</div>
<br />
<p>- Chusslove</p>
<br />
<p>On August 28th, 2013, 4:17 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2013, 4:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Iterates over KUnitConversion, still not final:
- Stops using KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION
- Makes dependencies fixed:
- Removes runtime dependency on kioclient and links to Qt5::Network instead (adding a dependency to QtNetwork)
- Removes the ifdef and always depends on Solid for checking whether it's online. This dependency could go if we move it to QNetworkSession, if somebody thinks it makes sense, I can open a task for that.
- Removes kunitconversion-config.h, there are not different ways to build it now.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, unit tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kunitconversion/src/kunitconversion/CMakeLists.txt <span style="color: grey">(c9272ab)</span></li>
<li>staging/kunitconversion/src/kunitconversion/acceleration.cpp <span style="color: grey">(1a22330)</span></li>
<li>staging/kunitconversion/src/kunitconversion/angle.cpp <span style="color: grey">(31999b0)</span></li>
<li>staging/kunitconversion/src/kunitconversion/area.cpp <span style="color: grey">(c84ffd1)</span></li>
<li>staging/kunitconversion/src/kunitconversion/config-kunitconversion.h.cmake <span style="color: grey">(601dc1c)</span></li>
<li>staging/kunitconversion/src/kunitconversion/converter.cpp <span style="color: grey">(a433240)</span></li>
<li>staging/kunitconversion/src/kunitconversion/currency.cpp <span style="color: grey">(16c7fb2)</span></li>
<li>staging/kunitconversion/src/kunitconversion/density.cpp <span style="color: grey">(878f199)</span></li>
<li>staging/kunitconversion/src/kunitconversion/energy.cpp <span style="color: grey">(7e5f8b3)</span></li>
<li>staging/kunitconversion/src/kunitconversion/force.cpp <span style="color: grey">(d933a9f)</span></li>
<li>staging/kunitconversion/src/kunitconversion/frequency.cpp <span style="color: grey">(55a99e9)</span></li>
<li>staging/kunitconversion/src/kunitconversion/fuel_efficiency.cpp <span style="color: grey">(6b16696)</span></li>
<li>staging/kunitconversion/src/kunitconversion/kcurrencycode.cpp <span style="color: grey">(09e40ac)</span></li>
<li>staging/kunitconversion/src/kunitconversion/length.cpp <span style="color: grey">(29211d9)</span></li>
<li>staging/kunitconversion/src/kunitconversion/mass.cpp <span style="color: grey">(a8dc69c)</span></li>
<li>staging/kunitconversion/src/kunitconversion/power.cpp <span style="color: grey">(30e123e)</span></li>
<li>staging/kunitconversion/src/kunitconversion/pressure.cpp <span style="color: grey">(ed849bb)</span></li>
<li>staging/kunitconversion/src/kunitconversion/temperature.cpp <span style="color: grey">(982f6bb8)</span></li>
<li>staging/kunitconversion/src/kunitconversion/timeunit.cpp <span style="color: grey">(a9341c4)</span></li>
<li>staging/kunitconversion/src/kunitconversion/unit.cpp <span style="color: grey">(f8c6217)</span></li>
<li>staging/kunitconversion/src/kunitconversion/unitcategory.cpp <span style="color: grey">(c7aaf27)</span></li>
<li>staging/kunitconversion/src/kunitconversion/value.cpp <span style="color: grey">(228ecfe)</span></li>
<li>staging/kunitconversion/src/kunitconversion/velocity.cpp <span style="color: grey">(1e5c817)</span></li>
<li>staging/kunitconversion/src/kunitconversion/volume.cpp <span style="color: grey">(02d8eee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112331/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>