<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112177/">http://git.reviewboard.kde.org/r/112177/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4a3118b33f2089904098684efe17f642c4980a55 by Albert Vaca to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 27th, 2013, 9:49 a.m. UTC, Albert Vaca Cintora wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Albert Vaca Cintora.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2013, 9:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The replace content on URL drop functionality that was present in KLineEdit has been moved to a separate class, that can be installed as an event filter in any QLineEdit (KLineEdit, QComboBox, KUrlRequester...).
KLineEdit now uses this new class when the property "urlDropsEnabled" is enabled, but this property has been marked as deprecated in favour of the new alternative.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing + tests passed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kwidgetsaddons/src/lineediturldropeventfilter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/src/lineediturldropeventfilter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(c17c648)</span></li>
<li>staging/kcompletion/src/klineedit.cpp <span style="color: grey">(213b196)</span></li>
<li>staging/kcompletion/src/klineedit.h <span style="color: grey">(e9f3332)</span></li>
<li>staging/kcompletion/src/kcombobox.h <span style="color: grey">(0d4e912)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112177/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>