<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112279/">http://git.reviewboard.kde.org/r/112279/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112279/diff/1/?file=184606#file184606line89" style="color: black; font-weight: bold; text-decoration: underline;">staging/frameworkintegration/src/platformtheme/kfontsettingsdata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KFontSettingsData::dropFontSettingsCache()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">QGui</span>App<span class="hl">lication</span></span><span class="o"><span class="hl">::</span></span><span class="n">setFont</span><span class="p">(</span> <span class="o">*</span><span class="n">font</span><span class="p">(</span><span class="n">KFontSettingsData</span><span class="o">::</span><span class="n">GeneralFont</span><span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>App</span><span class="o"><span class="hl">-></span></span><span class="n">setFont</span><span class="p">(</span> <span class="o">*</span><span class="n">font</span><span class="p">(</span><span class="n">KFontSettingsData</span><span class="o">::</span><span class="n">GeneralFont</span><span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's much less dynamic than you make it sound. It's a macro which static casts to QApplication. And setFont being static on both classes there's no chance for polymorphism... so it's always the QApplication variant being called here.
Looking at QApplication::setFont() it chains properly to QGuiApplication, but for the rest of the implementation there's a part I would suspect to create troubles in case of a QGuiApplication but I'm not sure (seems to read QApplicationPrivate fields without checking if we have a full fledged QApplication).
Has this change been tested with an application having only a QGuiApplication?</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On August 25th, 2013, 10:42 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2013, 10:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use QApplication::setFont or QGuiApplication::setFont depending on what qApp pointer is.
This makes font change events be propagated to widgets.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/frameworkintegration/src/platformtheme/kfontsettingsdata.cpp <span style="color: grey">(70c1d26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112279/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>