<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112292/">http://git.reviewboard.kde.org/r/112292/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2013, 6:25 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if you want to see the language codes we have, they are listed in http://websvn.kde.org/trunk/l10n-kde4/
To be honest i don't see why we need conversion between uiLanguages and here since uiLanguages returns what we is set in LANGUAGE ./corelib/tools/qlocale_unix.cpp:231: case UILanguages:
which we do set in KCatalog
So basically should be returning "our stuff", no?
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It does return $LANGUAGE, but it changes the format by adding a '-' instead of '_'. Do you think qlocale_unix should be patched up instead? Because it is inconsistent with QLocale::name() which uses '_'
So Qt code like this would fail -
QLocale locale;
locale.uiLanguages().contains(locale.name()); // <---- will return false!</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On August 26th, 2013, 2:48 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Albert Astals Cid, Aleix Pol Gonzalez, and Chusslove Illich.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2013, 2:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Make KLocalizedString::isApplicationTranslatedInto & QLocale::uiLanguages compatible
QLocale::uiLanguages returns "lang-script-country" whereas KCatalog
expects the format to be "lang_countr@script". We need to convert the
format before checking if the corresponding catalog exists.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Limited testing done. My QLocale::uiLanguages() returns "en-US" which is correctly converted to "en_US". I haven't tested it with anything else. Any tips on how I should go about testing this?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/ki18n/src/klocalizedstring.cpp <span style="color: grey">(eab9216)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112292/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>