<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112174/">http://git.reviewboard.kde.org/r/112174/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 84ffcc8b2434a14db400b57044ad099418c55036 by Alex Richardson to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 20th, 2013, 4:48 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2013, 4:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make KSharedConfig::Ptr use QExplicitlySharedDataPointer
QExplicitlySharedDataPointer does the same as KSharedPtr with only
slightly different API</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and installs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kde4attic/src/localization/klocale_kde.cpp <span style="color: grey">(2ad32083f8f7e59d140acbbf02766bf638c4207b)</span></li>
<li>staging/kde4support/src/kdecore/kcomponentdata.cpp <span style="color: grey">(9c9e50904cd8663ec676e36bfed8e74ab3c1db19)</span></li>
<li>staging/kde4support/src/kdecore/kglobal.h <span style="color: grey">(056847f5152dcd1dd32e953d88b57c79c799fab1)</span></li>
<li>staging/kio/src/core/kprotocolmanager.h <span style="color: grey">(cb370358cb5c4b789cd3431ae0b82cc6708c20b7)</span></li>
<li>tier1/kconfig/src/core/kconfiggroup.h <span style="color: grey">(928b64d933a54c33456cdacc41fea83a7a36e046)</span></li>
<li>tier1/kconfig/src/core/ksharedconfig.h <span style="color: grey">(b8f0175e5b2a81fc677286786ea4327695917e65)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112174/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>