<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112037/">http://git.reviewboard.kde.org/r/112037/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Teo Mrnjavac.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2013, 1:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support.
kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic)
Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical.
With this all uses of KFileDialog are removed, except for KEncodingFileDialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does not break any tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kdirselectdialog.cpp <span style="color: grey">(dcbcc4cf743bad17cfa520def611445ceb31eb21)</span></li>
<li>kio/kfile/kfiledialog.h <span style="color: grey">(216dcc8b41e3a9027b2a94b307d6c6374ee53c51)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(995e962353a09e40f627f2db60ce831b46b6a414)</span></li>
<li>kio/kfile/kurlrequester.h <span style="color: grey">(bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f)</span></li>
<li>kio/kfile/kurlrequester.cpp <span style="color: grey">(523ae7a3bec64a3d997a255899cb15a8fdc5689e)</span></li>
<li>kio/kfile/kurlrequesterdialog.h <span style="color: grey">(2e515b23060748e632cc96eed4a2305f67ebb40e)</span></li>
<li>kio/kfile/kurlrequesterdialog.cpp <span style="color: grey">(b0afd16388dab56b0a1127dd6e8921476196f234)</span></li>
<li>kio/kssl/kcm/cacertificatespage.cpp <span style="color: grey">(8b35c2a73f0f2caa3e385568d32428fdbb00bba4)</span></li>
<li>kparts/browserrun.cpp <span style="color: grey">(ff3a5fd1220cf0be3c8775cf97f204f3a26300d0)</span></li>
<li>kross/ui/view.cpp <span style="color: grey">(51f31c5bc247d385c685cf91a94c48a0ed855532)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112037/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>