<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112060/">http://git.reviewboard.kde.org/r/112060/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2013, 10:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fix issues pointed by ervin</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything in staging directory (except kde4support)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds (with prefix removed) and tests looks OK.
Testes with other changes (CMake part1, part2)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kemoticons/src/providers/pidgin/CMakeLists.txt <span style="color: grey">(242807d)</span></li>
<li>staging/kemoticons/src/providers/kde/CMakeLists.txt <span style="color: grey">(8602909)</span></li>
<li>staging/kemoticons/src/providers/adium/CMakeLists.txt <span style="color: grey">(2ad9512)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.cpp <span style="color: grey">(725c9c1)</span></li>
<li>staging/kemoticons/src/core/CMakeLists.txt <span style="color: grey">(de6640b)</span></li>
<li>staging/kemoticons/autotests/CMakeLists.txt <span style="color: grey">(b00056a)</span></li>
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(f395cd5)</span></li>
<li>staging/kde4attic/tests/CMakeLists.txt <span style="color: grey">(fd7fd3a)</span></li>
<li>staging/kcrash/src/CMakeLists.txt <span style="color: grey">(5bdaf61)</span></li>
<li>staging/kde4attic/autotests/CMakeLists.txt <span style="color: grey">(9e3d488)</span></li>
<li>staging/kconfigwidgets/tests/CMakeLists.txt <span style="color: grey">(919342f)</span></li>
<li>staging/kconfigwidgets/src/CMakeLists.txt <span style="color: grey">(0ec0987)</span></li>
<li>staging/kconfigwidgets/autotests/CMakeLists.txt <span style="color: grey">(3afeccc)</span></li>
<li>staging/kcompletion/tests/CMakeLists.txt <span style="color: grey">(22050fc)</span></li>
<li>staging/kcompletion/src/CMakeLists.txt <span style="color: grey">(9ef378c)</span></li>
<li>staging/kcompletion/autotests/CMakeLists.txt <span style="color: grey">(25fee98)</span></li>
<li>staging/itemviews/tests/CMakeLists.txt <span style="color: grey">(68dd537)</span></li>
<li>staging/itemviews/src/CMakeLists.txt <span style="color: grey">(45b76e1)</span></li>
<li>staging/itemviews/autotests/CMakeLists.txt <span style="color: grey">(a122958)</span></li>
<li>staging/frameworkintegration/src/platformtheme/CMakeLists.txt <span style="color: grey">(ec20115)</span></li>
<li>staging/frameworkintegration/src/integrationplugin/CMakeLists.txt <span style="color: grey">(437f0e7)</span></li>
<li>experimental/kdeclarative/CMakeLists.txt <span style="color: grey">(6c9b088)</span></li>
<li>staging/kemoticons/src/providers/xmpp/CMakeLists.txt <span style="color: grey">(55330ce)</span></li>
<li>staging/kemoticons/tests/CMakeLists.txt <span style="color: grey">(ea7fc0b)</span></li>
<li>staging/kguiaddons/autotests/CMakeLists.txt <span style="color: grey">(772caee)</span></li>
<li>staging/kguiaddons/src/CMakeLists.txt <span style="color: grey">(fc8941a)</span></li>
<li>staging/kguiaddons/tests/CMakeLists.txt <span style="color: grey">(ab44a37)</span></li>
<li>staging/ki18n/src/CMakeLists.txt <span style="color: grey">(f80bae6)</span></li>
<li>staging/kiconthemes/autotests/CMakeLists.txt <span style="color: grey">(854cbe3)</span></li>
<li>staging/kiconthemes/src/CMakeLists.txt <span style="color: grey">(150eb1a)</span></li>
<li>staging/kiconthemes/tests/CMakeLists.txt <span style="color: grey">(49f179c)</span></li>
<li>staging/kinterprocesswindowing/src/CMakeLists.txt <span style="color: grey">(0cb849a)</span></li>
<li>staging/kio/autotests/CMakeLists.txt <span style="color: grey">(b43ac26)</span></li>
<li>staging/kio/src/core/CMakeLists.txt <span style="color: grey">(be00bbe)</span></li>
<li>staging/kio/src/kssld/CMakeLists.txt <span style="color: grey">(f030a65)</span></li>
<li>staging/kio/src/widgets/CMakeLists.txt <span style="color: grey">(f68034c)</span></li>
<li>staging/kjobwidgets/autotests/CMakeLists.txt <span style="color: grey">(559ba28)</span></li>
<li>staging/kjobwidgets/src/CMakeLists.txt <span style="color: grey">(e160da0)</span></li>
<li>staging/kjobwidgets/tests/CMakeLists.txt <span style="color: grey">(7e5331a)</span></li>
<li>staging/knotifications/autotests/CMakeLists.txt <span style="color: grey">(b12bff6)</span></li>
<li>staging/knotifications/tests/CMakeLists.txt <span style="color: grey">(91d46cf)</span></li>
<li>staging/kservice/autotests/CMakeLists.txt <span style="color: grey">(326bbf9)</span></li>
<li>staging/kservice/src/CMakeLists.txt <span style="color: grey">(893f6dd)</span></li>
<li>staging/kservice/tests/CMakeLists.txt <span style="color: grey">(5e94b81)</span></li>
<li>staging/ktextwidgets/autotests/CMakeLists.txt <span style="color: grey">(4c2b9d6)</span></li>
<li>staging/ktextwidgets/src/CMakeLists.txt <span style="color: grey">(1f47da2)</span></li>
<li>staging/ktextwidgets/tests/CMakeLists.txt <span style="color: grey">(3dd1376)</span></li>
<li>staging/kunitconversion/autotests/CMakeLists.txt <span style="color: grey">(c041a91)</span></li>
<li>staging/kunitconversion/src/kunitconversion/CMakeLists.txt <span style="color: grey">(3d6771b)</span></li>
<li>staging/kwallet/autotests/CMakeLists.txt <span style="color: grey">(95535ca)</span></li>
<li>staging/kwallet/src/CMakeLists.txt <span style="color: grey">(d181426)</span></li>
<li>staging/kwallet/tests/CMakeLists.txt <span style="color: grey">(c75ff00)</span></li>
<li>staging/xmlgui/autotests/CMakeLists.txt <span style="color: grey">(6b415ba)</span></li>
<li>staging/xmlgui/src/CMakeLists.txt <span style="color: grey">(9731f98)</span></li>
<li>staging/xmlgui/tests/CMakeLists.txt <span style="color: grey">(3f17e9a)</span></li>
<li>staging/xmlgui/tests/krichtexteditor/CMakeLists.txt <span style="color: grey">(4007776)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112060/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>