<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112037/">http://git.reviewboard.kde.org/r/112037/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2013, 7:25 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112037/diff/1/?file=178338#file178338line408" style="color: black; font-weight: bold; text-decoration: underline;">kfile/kdirselectdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KDirSelectDialog::KDirSelectDialog(const QUrl &startDir, bool localOnly,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">372</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">m_startURL</span> <span class="o">=</span> <span class="n"><span class="hl">KF</span>ile<span class="hl">Dialog</span></span><span class="o"><span class="hl">::</span></span><span class="n">getStartUrl</span><span class="p">(</span> <span class="n">startDir</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_recentDirClass</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">403</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">m_startURL</span> <span class="o">=</span> <span class="n"><span class="hl">f</span>ile<span class="hl">Module</span></span><span class="p"><span class="hl">()</span></span><span class="o"><span class="hl">-></span></span><span class="n">getStartUrl</span><span class="p">(</span> <span class="n">startDir</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_recentDirClass</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmmm it makes me realize, couldn't KEncodingFileDialog be made to depend on the file module only? That would remove the dependency on KFileDialog (the file module is planned to stay).</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've investigated a bit, and we could try to make KEncodingFileDialog static-only.
The majority of KEncodingFileDialog uses are static, however in a few instances kdepim/messagecomposer uses KEncodingFileDialog with instantiation and some customization (e.g. http://lxr.kde.org/source/kde/kdepim/messagecomposer/attachment/attachmentcontrollerbase.cpp#770).
Maybe we can factor this into a separate kdelibs cleanups dashboard task that would involve staticifying KEncodingFileDialog while making sure kdepim can get what it needs.</pre>
<br />
<p>- Teo</p>
<br />
<p>On August 15th, 2013, 3:36 p.m. UTC, Teo Mrnjavac wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Teo Mrnjavac.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2013, 3:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support.
kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic)
Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical.
With this all uses of KFileDialog are removed, except for KEncodingFileDialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does not break any tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kdirselectdialog.cpp <span style="color: grey">(dcbcc4cf743bad17cfa520def611445ceb31eb21)</span></li>
<li>kio/kfile/kfiledialog.h <span style="color: grey">(216dcc8b41e3a9027b2a94b307d6c6374ee53c51)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(995e962353a09e40f627f2db60ce831b46b6a414)</span></li>
<li>kio/kfile/kurlrequester.h <span style="color: grey">(bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f)</span></li>
<li>kio/kfile/kurlrequester.cpp <span style="color: grey">(523ae7a3bec64a3d997a255899cb15a8fdc5689e)</span></li>
<li>kio/kfile/kurlrequesterdialog.h <span style="color: grey">(2e515b23060748e632cc96eed4a2305f67ebb40e)</span></li>
<li>kio/kfile/kurlrequesterdialog.cpp <span style="color: grey">(b0afd16388dab56b0a1127dd6e8921476196f234)</span></li>
<li>kio/kssl/kcm/cacertificatespage.cpp <span style="color: grey">(8b35c2a73f0f2caa3e385568d32428fdbb00bba4)</span></li>
<li>kparts/browserrun.cpp <span style="color: grey">(ff3a5fd1220cf0be3c8775cf97f204f3a26300d0)</span></li>
<li>kross/ui/view.cpp <span style="color: grey">(51f31c5bc247d385c685cf91a94c48a0ed855532)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112037/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>