<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112038/">http://git.reviewboard.kde.org/r/112038/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 2dd9af275d81b35f30335630c8144b17ba80f8c3 by Christophe Giboudeaux to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 13th, 2013, 2:28 p.m. UTC, Christophe Giboudeaux wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Stephen Kelly.</div>
<div>By Christophe Giboudeaux.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2013, 2:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The issue was uncovered by https://git.reviewboard.kde.org/r/111937. LibAttica::attica is in the LINK_PUBLIC entries for XmlGui and in the IMPORTED_LINK_DEPENDENT_LIBRARIES for KDE4__knewstuff3 but none of these is looking for Attica.
With this patch, both KDELibs4Config.cmake and XmlGuiConfig.cmake look for Attica.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Konsole build with https://git.reviewboard.kde.org/r/111937 without the 'find_package(LibAttica NO_MODULE) line'.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDELibs4Config.cmake <span style="color: grey">(bd91efb)</span></li>
<li>staging/xmlgui/XmlGuiConfig.cmake.in <span style="color: grey">(08da417)</span></li>
<li>staging/xmlgui/src/CMakeLists.txt <span style="color: grey">(46dc74a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112038/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>