<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111945/">http://git.reviewboard.kde.org/r/111945/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111945/diff/1/?file=177388#file177388line15" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kconfig/src/gui/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">KConfigGui</span> <span class="s">Qt5::Widgets</span> <span class="s">KConfigCore</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">KConfigGui</span> <span class="s"><span class="hl">LINK_PUBLIC</span></span><span class="hl"> </span><span class="s"><span class="hl">Qt5::Core</span></span><span class="hl"> </span><span class="s">Qt5::Widgets</span> <span class="s">KConfigCore</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The LINK_PUBLIC is ok here, but is the Qt5::Core necessary? Doesn't it get picked up by transitivity with KConfigCore?
Just wondering, I admit I'm unsure.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111945/diff/1/?file=177392#file177392line55" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kidletime/src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">KIdleTime</span> <span class="s">LINK_PRIVATE</span> <span class="s">Qt5::Widgets</span> <span class="o">${</span><span class="nv">kidletime_LIBS</span><span class="o">}</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the space before )</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111945/diff/1/?file=177400#file177400line13" style="color: black; font-weight: bold; text-decoration: underline;">tier1/sonnet/autotests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="o">${</span><span class="nv">_testname</span><span class="o">}</span> <span class="s">SonnetCore</span> <span class="s">Qt5::Test</span> <span class="s"><span class="hl">Qt5::Xml</span></span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="o">${</span><span class="nv">_testname</span><span class="o">}</span> <span class="s">SonnetCore</span> <span class="s">Qt5::Test</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the space before )</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111945/diff/1/?file=177401#file177401line12" style="color: black; font-weight: bold; text-decoration: underline;">tier1/sonnet/src/plugins/aspell/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kspell_aspell</span> <span class="s">SonnetCore</span> <span class="o">${</span><span class="nv">ASPELL_LIBRARIES</span><span class="o">}</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kspell_aspell</span> <span class="s"><span class="hl">LINK_PRIVATE</span></span><span class="hl"> </span><span class="s">SonnetCore</span> <span class="o">${</span><span class="nv">ASPELL_LIBRARIES</span><span class="o">}</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the space before )</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111945/diff/1/?file=177402#file177402line11" style="color: black; font-weight: bold; text-decoration: underline;">tier1/sonnet/src/plugins/enchant/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kspell_enchant</span> <span class="s">SonnetCore</span> <span class="o">${</span><span class="nv">ENCHANT_LIBRARIES</span><span class="o">}</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kspell_enchant</span> <span class="s"><span class="hl">LINK_PRIVATE</span></span><span class="hl"> </span><span class="s">SonnetCore</span> <span class="o">${</span><span class="nv">ENCHANT_LIBRARIES</span><span class="o">}</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the space before )</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111945/diff/1/?file=177403#file177403line12" style="color: black; font-weight: bold; text-decoration: underline;">tier1/sonnet/src/plugins/hspell/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kspell_hspell</span> <span class="s">SonnetCore</span> <span class="o">${</span><span class="nv">HSPELL_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">ZLIB_LIBRARY</span><span class="o">}</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kspell_hspell</span><span class="hl"> </span><span class="s"><span class="hl">LINK_PRIVATE</span></span> <span class="s">SonnetCore</span> <span class="o">${</span><span class="nv">HSPELL_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">ZLIB_LIBRARY</span><span class="o">}</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the space before )</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111945/diff/1/?file=177404#file177404line10" style="color: black; font-weight: bold; text-decoration: underline;">tier1/sonnet/src/plugins/hunspell/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kspell_hunspell</span> <span class="s">SonnetCore</span> <span class="o">${</span><span class="nv">HUNSPELL_LIBRARIES</span><span class="o">}</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kspell_hunspell</span> <span class="s"><span class="hl">LINK_PRIVATE</span></span><span class="hl"> </span><span class="s">SonnetCore</span> <span class="o">${</span><span class="nv">HUNSPELL_LIBRARIES</span><span class="o">}</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the space before )</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On August 8th, 2013, 4:09 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2013, 4:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Task from kdelibs cleanup.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds and tests looks OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kconfig/src/core/CMakeLists.txt <span style="color: grey">(398a1d7)</span></li>
<li>tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt <span style="color: grey">(b04b867)</span></li>
<li>tier1/kconfig/autotests/CMakeLists.txt <span style="color: grey">(751396f)</span></li>
<li>tier1/kconfig/src/gui/CMakeLists.txt <span style="color: grey">(91f013b)</span></li>
<li>tier1/kdbusaddons/autotests/CMakeLists.txt <span style="color: grey">(bf03734)</span></li>
<li>tier1/kdbusaddons/src/CMakeLists.txt <span style="color: grey">(25d1f60)</span></li>
<li>tier1/kdbusaddons/tests/CMakeLists.txt <span style="color: grey">(57e6d4f)</span></li>
<li>tier1/kidletime/src/CMakeLists.txt <span style="color: grey">(d709b2b)</span></li>
<li>tier1/kjs/src/kjs/CMakeLists.txt <span style="color: grey">(ebbb820)</span></li>
<li>tier1/kjs/src/kjs/api/CMakeLists.txt <span style="color: grey">(4d5c5d6)</span></li>
<li>tier1/kplotting/autotests/CMakeLists.txt <span style="color: grey">(afebdee)</span></li>
<li>tier1/kplotting/src/CMakeLists.txt <span style="color: grey">(7ce75bd)</span></li>
<li>tier1/kwidgetsaddons/autotests/CMakeLists.txt <span style="color: grey">(870e16e)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(c64302a)</span></li>
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(fe0f920)</span></li>
<li>tier1/sonnet/autotests/CMakeLists.txt <span style="color: grey">(88574ff)</span></li>
<li>tier1/sonnet/src/plugins/aspell/CMakeLists.txt <span style="color: grey">(70f06d1)</span></li>
<li>tier1/sonnet/src/plugins/enchant/CMakeLists.txt <span style="color: grey">(2319be8)</span></li>
<li>tier1/sonnet/src/plugins/hspell/CMakeLists.txt <span style="color: grey">(c7cafc5)</span></li>
<li>tier1/sonnet/src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(a0e2d9b)</span></li>
<li>tier1/sonnet/src/ui/CMakeLists.txt <span style="color: grey">(723d8f3)</span></li>
<li>tier1/sonnet/src/unicode/CMakeLists.txt <span style="color: grey">(6b5d27d)</span></li>
<li>tier1/sonnet/tests/CMakeLists.txt <span style="color: grey">(6e0e450)</span></li>
<li>tier1/threadweaver/src/WeaverGui/CMakeLists.txt <span style="color: grey">(f92577c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111945/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>