<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111897/">http://git.reviewboard.kde.org/r/111897/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Kevin</p>
<br />
<p>On August 8th, 2013, 11:59 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Vishesh Handa.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2013, 11:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support.
It's worth noting that there are 2 "plugins" (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/CMakeLists.txt <span style="color: grey">(89c09ec)</span></li>
<li>kio/kfile/kcommentwidget.cpp <span style="color: grey">(f125bc7)</span></li>
<li>kio/kfile/kcommentwidget_p.h <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadataconfigurationwidget.h <span style="color: grey">(6be2a0d)</span></li>
<li>kio/kfile/kfilemetadataconfigurationwidget.cpp <span style="color: grey">(5fbf8dc)</span></li>
<li>kio/kfile/kfilemetadataprovider.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadataprovider_p.h <span style="color: grey">(8009bf4)</span></li>
<li>kio/kfile/kfilemetadatareader.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadatareader_p.h <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadatareaderprocess.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadatawidget.h <span style="color: grey">(2dc4677)</span></li>
<li>kio/kfile/kfilemetadatawidget.cpp <span style="color: grey">(6e0f106)</span></li>
<li>kio/kfile/kmetaprops.h <span style="color: grey">(a08c380)</span></li>
<li>kio/kfile/kmetaprops.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/knfotranslator.cpp <span style="color: grey">(64bcecc)</span></li>
<li>kio/kfile/knfotranslator_p.h <span style="color: grey">()</span></li>
<li>kio/kfile/kpreviewprops.h <span style="color: grey">(8a974da)</span></li>
<li>kio/kfile/kpreviewprops.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(687e4bf)</span></li>
<li>kio/kio/dummyanalyzers/CMakeLists.txt <span style="color: grey">()</span></li>
<li>kio/kio/dummyanalyzers/dummyanalyzers.cpp <span style="color: grey">()</span></li>
<li>kio/kio/kfilemetainfo.h <span style="color: grey">(ddd26d3)</span></li>
<li>kio/kio/kfilemetainfo.cpp <span style="color: grey">(a87a8a0)</span></li>
<li>kio/kio/kfilemetainfoitem.h <span style="color: grey">(b414274)</span></li>
<li>kio/kio/kfilemetainfoitem.cpp <span style="color: grey">(fbaefe0)</span></li>
<li>kio/kio/kfilemetainfoitem_p.h <span style="color: grey">(607ac3e)</span></li>
<li>kio/kio/kfilewrite.desktop <span style="color: grey">()</span></li>
<li>kio/kio/kfilewriteplugin.h <span style="color: grey">()</span></li>
<li>kio/kio/kfilewriteplugin.cpp <span style="color: grey">()</span></li>
<li>kio/kio/kfilewriteplugin_p.h <span style="color: grey">()</span></li>
<li>kio/kio/predicateproperties.h <span style="color: grey">()</span></li>
<li>kio/kio/predicateproperties.cpp <span style="color: grey">()</span></li>
<li>kio/tests/CMakeLists.txt <span style="color: grey">(e6deb62)</span></li>
<li>kio/tests/kfilemetainfotest.h <span style="color: grey">()</span></li>
<li>kio/tests/kfilemetainfotest.cpp <span style="color: grey">(74d518b)</span></li>
<li>kio/tests/kmfitest.cpp <span style="color: grey">()</span></li>
<li>kioslave/CMakeLists.txt <span style="color: grey">(c16b33e)</span></li>
<li>kioslave/metainfo/CMakeLists.txt <span style="color: grey">(a448576)</span></li>
<li>kioslave/metainfo/metainfo.h <span style="color: grey">()</span></li>
<li>kioslave/metainfo/metainfo.cpp <span style="color: grey">()</span></li>
<li>kioslave/metainfo/metainfo.protocol <span style="color: grey">()</span></li>
<li>staging/kde4support/autotests/CMakeLists.txt <span style="color: grey">(22da9ae)</span></li>
<li>staging/kde4support/autotests/kiotesthelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(4ea3497)</span></li>
<li>staging/kde4support/src/config-kde4support.h.cmake <span style="color: grey">(03d3bf4)</span></li>
<li>staging/kde4support/src/kioslave/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kioslave/metainfo/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/tests/CMakeLists.txt <span style="color: grey">(41e35ce)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111897/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>