<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111910/">http://git.reviewboard.kde.org/r/111910/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 7th, 2013, 4:25 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for that review.
So, profiles() and setProfile() are used? For which purpose?</pre>
</blockquote>
<p>On August 7th, 2013, 7:46 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">profiles() is used quite extensively in kdepim, it iterates over profiles looking for an email address (aka "is this particular email address among user's email addresses"), see http://lxr.kde.org/source/kde/kdepimlibs/kcal/incidenceformatter.cpp#117 for example.
setProfile() is imho a bit misued, it's used as
KEMailSettings es;
es.setProfile( es.defaultProfileName() );
however this already happens in constructor. These are the only usages of setProfile() I've found, so I'd be happy to deprecate it as well as it's a bit redundant. I didn't because it breaks quite a lot of code, on the other hand I think that's expected with kf5...</pre>
</blockquote>
<p>On August 7th, 2013, 8:39 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, I see. Nasty stateful API, having to "setProfile" in order to read the settings (e.g. email) in that profile. Could be improved, but OK, not worth it.
I'm still wondering if any code actually *writes* into multiple "profiles".
kdepimlibs' IdentityManager assumes KEMailSettings only has the "default profile", i.e. it only writes out the default identity into kemailsettings.
But OK, that could be considered a bug, since other code (e.g. the one in kcal) assumes that all emails will be in profiles.
OK, so bad API and incomplete usage, but we can't get rid of it :-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I'm still wondering if any code actually *writes* into multiple "profiles".
I wondered the same and I haven't found any writes to other profiles, everyone is just setting the default profile (I wonder if it was added to the constructor only after many people were unhappy having to set what should be the default or they simply didn't know...either way, I'll update the documentation to say that this is happening).</pre>
<br />
<p>- Martin</p>
<br />
<p>On August 6th, 2013, 2:30 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2013, 2:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've looked through all usages of KEMailSettings on lxr, deprecated things in diff are nowhere used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kio/src/core/kemailsettings.h <span style="color: grey">(873c222)</span></li>
<li>staging/kio/src/core/kemailsettings.cpp <span style="color: grey">(39dc9f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111910/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>