<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111927/">http://git.reviewboard.kde.org/r/111927/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3d00e4b21a89eb19dd2e2101e1a8141604f2b2c2 by Sebastian Kügler to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 7th, 2013, 12:37 a.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Aug. 7, 2013, 12:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove K_EXPORT_PLUGIN throughout.
The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The macro is in fact already a no-op. I have this branch split out in patches per module.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No regressions observed in tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp <span style="color: grey">(b5b0f7b)</span></li>
<li>kfile/kfilemodule.cpp <span style="color: grey">(1c51d16)</span></li>
<li>kio/kssl/kcm/kcmssl.cpp <span style="color: grey">(6dd19e4)</span></li>
<li>kio/misc/kpac/proxyscout.cpp <span style="color: grey">(6451c04)</span></li>
<li>kioslave/http/kcookiejar/kcookieserver.cpp <span style="color: grey">(5432859)</span></li>
<li>kparts/tests/notepad.cpp <span style="color: grey">(5eb9fcf)</span></li>
<li>kparts/tests/plugin_spellcheck.cpp <span style="color: grey">(15509d8)</span></li>
<li>kutils/kcmodulecontainer.h <span style="color: grey">(db6e435)</span></li>
<li>kutils/ksettings/README.dox <span style="color: grey">(7f2210d)</span></li>
<li>kutils/ksettings/pluginpage.h <span style="color: grey">(ded17e7)</span></li>
<li>staging/kconfigwidgets/src/kcmodule.h <span style="color: grey">(74333c1)</span></li>
<li>staging/kde4support/autotests/klibloadertest4_module.cpp <span style="color: grey">(7c1eec2)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">(35414e9)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">(570afb3)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">(d24792f)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">(12ee96a)</span></li>
<li>staging/kio/src/kssld/kssld.cpp <span style="color: grey">(52bc7b6)</span></li>
<li>staging/kio/src/widgets/kabstractfileitemactionplugin.h <span style="color: grey">(19b872b)</span></li>
<li>staging/kservice/src/plugin/kpluginloader.h <span style="color: grey">(7562ee4)</span></li>
<li>tier1/kconfig/src/core/kconfigbackend.h <span style="color: grey">(bce9fd1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111927/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>