<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111897/">http://git.reviewboard.kde.org/r/111897/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 6th, 2013, 9 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was just working on the same thing.
I'm not sure if we want to move this to kde4support. Can we just throw it away? Or would that be terribly wrong? We have a replacement in nepomuk-widgets.
Strigi doesn't need to be ported to Qt5 since it is does not use Qt. Soprano will have to be, but I don't think this code uses Soprano.</pre>
</blockquote>
<p>On August 6th, 2013, 10:13 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You were working on it? -.- it didn't have your name on it...
I think that the classes called plugin should be removed, there's not much else to remove otherwise.</pre>
</blockquote>
<p>On August 6th, 2013, 10:41 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd just started today morning, then I decided to try and compile everything. It has been 5 hours since then. I'm still compiling.
There is just one user visible class - KFileMetadataWidget. The rest of the classes are helper code. A large part of the helper code uses Nepomuk1. If we move this to kde4support, then those Nepomuk1 dependencies have to be removed. Removing them would make this into a wrapper over Strigi. The question is - do we want that? Or do we just want to discard this class completely?
Based on [1] there seem to be 3 clients. Dolphin which uses it when Nepomuk compilation is disabled. Conquirere, which is a Nepomuk based app and should just use the one in nepomuk-widgets, and Konversation - I'm not sure what to do about them. If we throw away this class then we will just be breaking Konversation.
I'm obviously in favor of discarding the class. Opinions?
This also raises the larger question if we want classes in kde4support to depend on unmaintained code? (Strigi)
[1] http://lxr.kde.org/ident?i=KFileMetaDataWidget</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Dolphin which uses it when Nepomuk compilation is disabled.
Yes. However, I think we might want to drop the option to compile Dolphin without Nepomuk 2 when porting to Frameworks. Maintaining all the HAVE_NEPOMUK #ifdefs is not much fun, in particular not if the only benefit for the users who compile from source is that they can make Dolphin use unmaintained code.
> I'm obviously in favor of discarding the class. Opinions?
I think that this is a good idea. Maybe one could make it a typedef for (or a very thin wrapper around) Nepomuk2::MetaDataWidget? Then removing all this unmaintained code would even be a source compatible change. Maybe this is not possible right now because kdelibs cannot depend on nepomuk-widgets, but in the long term, it makes sense IMHO to have kde4support depend on all KDE libs that are required to make the porting as easy as possible.</pre>
<br />
<p>- Frank</p>
<br />
<p>On August 5th, 2013, 6:06 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Vishesh Handa.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2013, 6:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support.
It's worth noting that there are 2 "plugins" (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/CMakeLists.txt <span style="color: grey">(035cf70)</span></li>
<li>kio/kfile/kfilemetadataconfigurationwidget.h <span style="color: grey">(6be2a0d)</span></li>
<li>kio/kfile/kfilemetadataconfigurationwidget.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadataprovider.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadataprovider_p.h <span style="color: grey">(8009bf4)</span></li>
<li>kio/kfile/kfilemetadatareader.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadatareader_p.h <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadatareaderprocess.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kfilemetadatawidget.h <span style="color: grey">(2dc4677)</span></li>
<li>kio/kfile/kfilemetadatawidget.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kmetaprops.h <span style="color: grey">(a08c380)</span></li>
<li>kio/kfile/kmetaprops.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/knfotranslator.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/knfotranslator_p.h <span style="color: grey">()</span></li>
<li>kio/kfile/kpreviewprops.h <span style="color: grey">(8a974da)</span></li>
<li>kio/kfile/kpreviewprops.cpp <span style="color: grey">()</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(687e4bf)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(1d6369f)</span></li>
<li>staging/kde4support/src/config-kde4support.h.cmake <span style="color: grey">(03d3bf4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111897/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>