<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111792/">http://git.reviewboard.kde.org/r/111792/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me (I wrote the native-event-filter API in Qt5), thanks for killing KSystemEventFilter -- but please add a porting note to KDE5PORTING.html about that class. It's used outside kdelibs: http://lxr.kde.org/ident?i=KSystemEventFilter
</pre>
<br />
<p>- David</p>
<br />
<p>On July 30th, 2013, 8:34 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 30, 2013, 8:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port KWindowSystemPrivate to QAbstractNativeEventFilter
Obviously it's only filtering XCB events and the event filtering code
is ported to use XCB data types.
With this change the KSystemEventFilter is no longer needed and
therefore dropped.
Port NETWinInfo::event from XEvent to xcb_generic_event_t
Straight forward port just replacing the XLib code by XCB equivalent.
The logic of looped event compaction is dropped as inspecting the event
queue is not possible on XCB.
Port NETRootInfo::event from XEvent to xcb_generic_event_t
Straight forward port just replacing the XLib functionality to XCB.
The compaction logic got dropped as it was hard disabled anyway.
Note: this change currently breaks KWindowSystem as it also needs to
be ported.
Coding style cleanup of event handling related methods
Before adjusting the code let's have a proper coding style.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Part of it indirectly tested through KWin on 5. Window caption gets updated and that is triggered through NETWinInfo, so I am positively optimistic that all of it works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/ksystemeventfilter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/ksystemeventfilter_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/kwindowsystem_x11.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/netwm.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/netwm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111792/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>