<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111678/">http://git.reviewboard.kde.org/r/111678/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e84396d3ae07f4213276398e4d2b51fa456d08d8 by Kevin Ottens to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 25th, 2013, 7:01 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 25, 2013, 7:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">0d5e8a432b7b63357696dbf2fbed5633919bff6b adjusted the include path for the export file to be sonnet/sonnetfoo_export.h in the public header files. This broke the build as those files cannot be found in the current build directory.
To solve this problem the export files are now generated in a sub-directory sonnet, so that the path matches. In addition the includes in the private headers are adjusted to also look for sonnet/ so that they can find it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and installs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/sonnet/src/core/CMakeLists.txt <span style="color: grey">(7f6384a)</span></li>
<li>tier1/sonnet/src/core/client_p.h <span style="color: grey">(d168f1f)</span></li>
<li>tier1/sonnet/src/core/filter_p.h <span style="color: grey">(783a920)</span></li>
<li>tier1/sonnet/src/core/loader_p.h <span style="color: grey">(f505510)</span></li>
<li>tier1/sonnet/src/core/settings_p.h <span style="color: grey">(639a503)</span></li>
<li>tier1/sonnet/src/core/spellerplugin_p.h <span style="color: grey">(81eb9b8)</span></li>
<li>tier1/sonnet/src/ui/CMakeLists.txt <span style="color: grey">(7abbb73)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111678/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>