<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111650/">http://git.reviewboard.kde.org/r/111650/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good overall, I still think a typedef for QSharedPointer<FindMatchesJob> would be worth it.
I'm not giving the "ship it" because I'd like someone who knows RunnerManager internals better than me to review it as it clearly has an impact on the job memory management. Otherwise I'd approve it right away.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On July 23rd, 2013, 11:23 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 23, 2013, 11:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ThreadWeaver does not use Job* anymore which made the code compile fail and some connects being wrong.
This patch adjusts RunnerManager to also use QSharedPointer<FindMatchJob> instead of FindMatchJob*. It
simplifies a few things as we do no longer have to call e.g. qDeleteAll and fixes the incorrect connects.
The patch also enables C++11 as it uses auto.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, but couldn't run the unit tests (something is broken in my setup)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/private/runnerjobs.cpp <span style="color: grey">(a012a6c)</span></li>
<li>src/plasma/private/runnerjobs_p.h <span style="color: grey">(cf05324)</span></li>
<li>src/plasma/runnermanager.h <span style="color: grey">(ebeb029)</span></li>
<li>src/plasma/runnermanager.cpp <span style="color: grey">(46857f4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>