<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111649/">http://git.reviewboard.kde.org/r/111649/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 23rd, 2013, 6:47 p.m. UTC, <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the current state of dbusmenuqt ?
Can it be built against both Qt4 and Qt5 ?
If so, do they have different version numbers then ?
I don't like that an old version of FindDBusMenuQt.cmake will find the Qt4 version, while a newer version of FindDBusMenuQt.cmake will find only the Qt5 version.
A simple solution would be to add a FindDBusMenuQt5.cmake. This would make it very obvious, and the "old" file would just keep working.</pre>
</blockquote>
<p>On July 23rd, 2013, 7:06 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Qt4 and Qt5 versions have different library names: dbusmenu-qt.so vs debusmenu-qt5.so
I can add a FindDBusMenuQt5.cmake, but I guess that means removing FindDBusMenuQt.cmake, since I don't see much point in installing a find module for Qt4 based software here</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about the version numbers ?
They should have different SO versions.
If from some version on the library is Qt5, then you could decide based on the required version whether to search for the Qt4 or the Qt5 version of dbusmenuqt. This would be a good option.
Alternatively turn it into a FindDBusMenuQt5.cmake, and get rid of everything of the Qt4-version.
Having different files out there in the wild, both named FindDBusMenuQt.cmake, one searching only for the Qt4 version, and one searching only for the Qt5 version just means confusion for developers, and the people trying to fix their build problems.
</pre>
<br />
<p>- Alexander</p>
<br />
<p>On July 23rd, 2013, 11:16 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated July 23, 2013, 11:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prevent linking to Qt4 based DBusMenuQt
This fixes all sorts of weird crashes due to having an executable
linked to both Qt4 and Qt5</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdelibs no longer links to system dbusmenu-qt</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindDBusMenuQt.cmake <span style="color: grey">(c231aeac0fe118577fbd57e83320f59c6e6cc23d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111649/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>