<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111649/">http://git.reviewboard.kde.org/r/111649/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice.
Now that we have an all new file, we can make it really pretty and try to follow the cmake guidelines as close as possible.
So here we go
* please use ExactCase variable names, e.g. DBusMenuQt5_LIBRARIES instead of DBUSMENUQT5_LIBRARIES
* also for the _FOUND variable. This is set by find_package_handle_standard_args() automatically. Use the option find_package_handle_standard_args( ... FOUND_VAR DBusMenuQt5_FOUND ...) to make it set the DBusMenuQt5_FOUND instead of DBUSMENUQT5_FOUND
* when searching for the library, please search for DBusMenuQt5_LIBRARY (singular), and put that then into DBusMenuQt5_LIBRARIES. The _LIBRARY variable is the one which goes into the cache, and which can potentially be edited by the user. As interface of the Find-module PackageName_LIBRARIES should be used. Potentially the library found by a Find-module may need multiple libraries to be linked, that's why the plural form. And that's why the singular forms should go into the cache.
* The same for the include dirs. The find_path() call is good, and then put the result into DBusMenuQt5_INCLUDE_DIRS (plural). Also document the plural forms at the top (decide for yourself whether you also want to document the singular form variables).
* for mark_as_advanced() and find_package_handle_standard_args() the singular forms are the ones to use.
Thanks
Alex
</pre>
<br />
<p>- Alexander</p>
<br />
<p>On July 24th, 2013, 7:26 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated July 24, 2013, 7:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdelibs no longer links to system dbusmenu-qt</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c2f3cfcc84553a89992ff7cdd56bb3cf7a319661)</span></li>
<li>cmake/modules/FindDBusMenuQt.cmake <span style="color: grey">(c231aeac0fe118577fbd57e83320f59c6e6cc23d)</span></li>
<li>cmake/modules/FindDBusMenuQt5.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(6295988bc42fc91eb7e27f737dd7dcadf6ae14c8)</span></li>
<li>staging/knotifications/src/CMakeLists.txt <span style="color: grey">(cfaa38a88e20f8a87b0dbd13217521bc46dfa993)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111649/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>