<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111584/">http://git.reviewboard.kde.org/r/111584/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 23rd, 2013, 9:35 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111584/diff/1/?file=172213#file172213line25" style="color: black; font-weight: bold; text-decoration: underline;">tier1/sonnet/src/ui/configdialog.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <span class="hl"><</span>sonnetui_export.h<span class="hl">></span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <span class="hl">"</span>sonnetui_export.h<span class="hl">"</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you sure about this one and the followings? It's odd if you need them as it just change the priority order to look for said header (first in the cwd then in the include path).</pre>
</blockquote>
<p>On July 23rd, 2013, 9:42 a.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is what all the other headers do with "sonnetcore_export.h", so I did the same here.
The problem is that include/sonnet is not part of the include paths when using sonnet.
Alternatively I could change it to <sonnet/sonnetui_export.h> and do the same with all the "sonnetcore_export.h" includes</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, might need to be revisited from the cmake side, but for now I'd rather prefer if you change it to <sonnet/sonnetui_export.h> as you proposed (likewise with the core export).</pre>
<br />
<p>- Kevin</p>
<br />
<p>On July 18th, 2013, 10:29 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated July 18, 2013, 10:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use correct path for including export headers</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles.
Also my test project using KF5 now works without having to manually add more include paths</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/bookmarks/kbookmark.h <span style="color: grey">(dbcb8b0c5ff1e6205887b030d9bcd200b19f4180)</span></li>
<li>kio/kio/kfileitemdelegate.h <span style="color: grey">(0943f0c3090d378a2db092a879bab81d1882deb5)</span></li>
<li>staging/ktextwidgets/src/widgets/ktextedit.h <span style="color: grey">(04bf8d59d2b6aafa57049f6bf5ad4bdda4523166)</span></li>
<li>tier1/sonnet/src/ui/configdialog.h <span style="color: grey">(93dcbcac6684a8a8df80697ab2f7a8113abe1897)</span></li>
<li>tier1/sonnet/src/ui/configwidget.h <span style="color: grey">(8f23184888078968d406275f140b60332997f0aa)</span></li>
<li>tier1/sonnet/src/ui/dialog.h <span style="color: grey">(84947be62e121a011c3440aa91346057abe1988c)</span></li>
<li>tier1/sonnet/src/ui/highlighter.h <span style="color: grey">(e275aec84eb729bbff2a7f75c8468cc65cb93d8c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111584/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>