<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111650/">http://git.reviewboard.kde.org/r/111650/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Probably worth adding a typedef for QSharedPointer<FindMatchesJob>, just like threadweaver have one for QSharedPointer<Job></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111650/diff/1/?file=172964#file172964line126" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">126</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_definitions</span><span class="p">(</span><span class="s2">"-std=c++0x"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unneeded now, I pushed a similar patch this morning.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111650/diff/1/?file=172968#file172968line322" style="color: black; font-weight: bold; text-decoration: underline;">src/plasma/runnermanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">314</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">FindMatchesJob</span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="n">runJob</span> <span class="o">=</span> <span class="k">dynamic<span class="hl">_c</span>ast</span><span class="o"><</span><span class="n">FindMatchesJob</span><span class="hl"> </span><span class="o"><span class="hl">*></span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">job</span></span><span class="p"><span class="hl">);</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">322</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">QSharedPointer</span></span><span class="o"><span class="hl"><</span></span><span class="n">FindMatchesJob</span><span class="o"><span class="hl">></span></span><span class="hl"> </span><span class="n">runJob</span> <span class="o">=</span> <span class="n"><span class="hl">job</span></span><span class="p"><span class="hl">.</span></span><span class="n">dynamic<span class="hl">C</span>ast</span><span class="o"><</span><span class="n">FindMatchesJob</span><span class="o"><span class="hl">></span></span><span class="p"><span class="hl">();;</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could use auto here, also has a redundant ; at the end of the line.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On July 23rd, 2013, 8:12 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 23, 2013, 8:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ThreadWeaver does not use Job* anymore which made the code compile fail and some connects being wrong.
This patch adjusts RunnerManager to also use QSharedPointer<FindMatchJob> instead of FindMatchJob*. It
simplifies a few things as we do no longer have to call e.g. qDeleteAll and fixes the incorrect connects.
The patch also enables C++11 as it uses auto.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, but couldn't run the unit tests (something is broken in my setup)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d4d0a43)</span></li>
<li>src/plasma/private/runnerjobs.cpp <span style="color: grey">(a012a6c)</span></li>
<li>src/plasma/private/runnerjobs_p.h <span style="color: grey">(cf05324)</span></li>
<li>src/plasma/runnermanager.h <span style="color: grey">(ebeb029)</span></li>
<li>src/plasma/runnermanager.cpp <span style="color: grey">(46857f4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>