<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111424/">http://git.reviewboard.kde.org/r/111424/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, but does the test still crash? That doesn't sound good :)</pre>
 <br />









<p>- David</p>


<br />
<p>On July 21st, 2013, 6:24 p.m. UTC, Andrea Scarpino wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Andrea Scarpino.</div>


<p style="color: grey;"><i>Updated July 21, 2013, 6:24 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KRichTextWidget and KRichTextEdit to KTextWidgets.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.
KRichTextEditTest pass, krichtexteditor segfaults.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KDE5PORTING.html <span style="color: grey">(59a0e1c)</span></li>

 <li>kdeui/CMakeLists.txt <span style="color: grey">(d317598)</span></li>

 <li>kdeui/dialogs/klinkdialog.h <span style="color: grey">()</span></li>

 <li>kdeui/dialogs/klinkdialog.cpp <span style="color: grey">(e83d3e7)</span></li>

 <li>kdeui/tests/CMakeLists.txt <span style="color: grey">(14b62ae)</span></li>

 <li>kdeui/tests/krichtexteditor/CMakeLists.txt <span style="color: grey">(49d4b5d)</span></li>

 <li>kdeui/tests/krichtexteditor/krichtexteditor.h <span style="color: grey">()</span></li>

 <li>kdeui/tests/krichtexteditor/krichtexteditor.cpp <span style="color: grey">(8e3305c)</span></li>

 <li>kdeui/tests/krichtexteditor/krichtexteditorui.rc <span style="color: grey">()</span></li>

 <li>kdeui/tests/krichtexteditor/main.cpp <span style="color: grey">(c263108)</span></li>

 <li>kdeui/tests/krichtextedittest.h <span style="color: grey">()</span></li>

 <li>kdeui/tests/krichtextedittest.cpp <span style="color: grey">(0b91775)</span></li>

 <li>kdeui/widgets/krichtextedit.h <span style="color: grey">(3db647e)</span></li>

 <li>kdeui/widgets/krichtextedit.cpp <span style="color: grey">(52b33e2)</span></li>

 <li>kdeui/widgets/krichtextwidget.h <span style="color: grey">(67cb8c9)</span></li>

 <li>kdeui/widgets/krichtextwidget.cpp <span style="color: grey">(7cd3448)</span></li>

 <li>kdeui/widgets/nestedlisthelper.h <span style="color: grey">()</span></li>

 <li>kdeui/widgets/nestedlisthelper.cpp <span style="color: grey">(5d2295d)</span></li>

 <li>staging/ktextwidgets/autotests/CMakeLists.txt <span style="color: grey">(f6d9fd2)</span></li>

 <li>staging/ktextwidgets/src/CMakeLists.txt <span style="color: grey">(d3cabb1)</span></li>

 <li>staging/xmlgui/tests/CMakeLists.txt <span style="color: grey">(b3b5667)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111424/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>