<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111424/">http://git.reviewboard.kde.org/r/111424/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111424/diff/2/?file=172660#file172660line13" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/tests/krichtexteditor/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">krichtexteditor</span> <span class="o">${</span><span class="nv">KDE4_KDEUI_LIBS</span><span class="o">}</span> <span class="s">Qt5::Test</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">krichtexteditor</span> <span class="s">Qt5::Widgets</span> <span class="s">Qt5::Test</span> <span class="s">kwidgets</span> <span class="s">SonnetUi</span> <span class="s">KTextWidgets</span> <span class="s">XmlGui</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this framework is called now KWidgets</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111424/diff/2/?file=172673#file172673line7" style="color: black; font-weight: bold; text-decoration: underline;">staging/ktextwidgets/autotests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="o">${</span><span class="nv">_testname</span><span class="o">}</span> <span class="s">Qt5::Widgets</span> <span class="s">Qt5::Test</span> <span class="s">SonnetUi</span> <span class="s">KTextWidgets</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="o">${</span><span class="nv">_testname</span><span class="o">}</span> <span class="s">Qt5::Widgets</span> <span class="s">Qt5::Test</span> <span class="s">SonnetUi</span> <span class="s"><span class="hl">kwidgets</span></span><span class="hl"> </span><span class="s">KTextWidgets</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this framework is called now KWidgets</pre>
</div>
<br />
<p>- Wojciech</p>
<br />
<p>On July 21st, 2013, 1:54 p.m. UTC, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated July 21, 2013, 1:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KRichTextWidget and KRichTextEdit to KTextWidgets.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.
KRichTextEditTest pass, krichtexteditor segfaults.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(59a0e1c)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(d317598)</span></li>
<li>kdeui/dialogs/klinkdialog.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/klinkdialog.cpp <span style="color: grey">(e83d3e7)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(14b62ae)</span></li>
<li>kdeui/tests/krichtexteditor/CMakeLists.txt <span style="color: grey">(49d4b5d)</span></li>
<li>kdeui/tests/krichtexteditor/krichtexteditor.h <span style="color: grey">()</span></li>
<li>kdeui/tests/krichtexteditor/krichtexteditor.cpp <span style="color: grey">(8e3305c)</span></li>
<li>kdeui/tests/krichtexteditor/krichtexteditorui.rc <span style="color: grey">()</span></li>
<li>kdeui/tests/krichtexteditor/main.cpp <span style="color: grey">(c263108)</span></li>
<li>kdeui/tests/krichtextedittest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/krichtextedittest.cpp <span style="color: grey">(0b91775)</span></li>
<li>kdeui/widgets/krichtextedit.h <span style="color: grey">(3db647e)</span></li>
<li>kdeui/widgets/krichtextedit.cpp <span style="color: grey">(52b33e2)</span></li>
<li>kdeui/widgets/krichtextwidget.h <span style="color: grey">(67cb8c9)</span></li>
<li>kdeui/widgets/krichtextwidget.cpp <span style="color: grey">(7cd3448)</span></li>
<li>kdeui/widgets/nestedlisthelper.h <span style="color: grey">()</span></li>
<li>kdeui/widgets/nestedlisthelper.cpp <span style="color: grey">(5d2295d)</span></li>
<li>staging/ktextwidgets/autotests/CMakeLists.txt <span style="color: grey">(f6d9fd2)</span></li>
<li>staging/ktextwidgets/src/CMakeLists.txt <span style="color: grey">(d3cabb1)</span></li>
<li>staging/xmlgui/tests/CMakeLists.txt <span style="color: grey">(b3b5667)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111424/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>