<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111609/">http://git.reviewboard.kde.org/r/111609/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c39a5b1dcd91cdae7fc58e73c3a5d2d615f51d94 by Wojciech Kapuscinski to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 19th, 2013, 6:46 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated July 19, 2013, 6:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replace signals: with Q_SIGNALS: and slots with Q_SLOTS: everywhere in kdelibs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds (the same way like jenkins)
all tests OK</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(34faf20)</span></li>
<li>kdeui/dialogs/klinkdialog.h <span style="color: grey">(1d98548)</span></li>
<li>kdeui/sonnet/tests/test_dictionarycombobox.cpp <span style="color: grey">(51e4059)</span></li>
<li>kdeui/tests/krichtexteditor/krichtexteditor.h <span style="color: grey">(19cde36)</span></li>
<li>kdeui/util/kimagecache.cpp <span style="color: grey">(2f619a7)</span></li>
<li>kfile/kdiroperatordetailview_p.h <span style="color: grey">(a1ec72c)</span></li>
<li>kfile/kurlnavigatortogglebutton_p.h <span style="color: grey">(6760cd2)</span></li>
<li>kfile/tests/kurlnavigatortest.h <span style="color: grey">(4b19b61)</span></li>
<li>khtml/ecma/debugger/callstackdock.h <span style="color: grey">(0b11946)</span></li>
<li>khtml/ecma/debugger/consoledock.h <span style="color: grey">(a62c968)</span></li>
<li>khtml/ecma/debugger/debugdocument.h <span style="color: grey">(1dc7970)</span></li>
<li>khtml/html/html_objectimpl.h <span style="color: grey">(ba64c57)</span></li>
<li>khtml/khtml_settings.cpp <span style="color: grey">(5ed0aeb)</span></li>
<li>khtml/khtmlviewbarwidget.h <span style="color: grey">(b620466)</span></li>
<li>khtml/ui/findbar/khtmlfind_p.h <span style="color: grey">(a138e99)</span></li>
<li>khtml/ui/findbar/khtmlfindbar.h <span style="color: grey">(e051ffb)</span></li>
<li>khtml/ui/passwordbar/storepassbar.h <span style="color: grey">(0e38f1c)</span></li>
<li>kinit/klauncher.h <span style="color: grey">(cf5679d)</span></li>
<li>kio/kfile/kabstractfilewidget.h <span style="color: grey">(dbbda61)</span></li>
<li>kio/kfile/kcommentwidget_p.h <span style="color: grey">(95488ea)</span></li>
<li>kio/kio/delegateanimationhandler_p.h <span style="color: grey">(bd26006)</span></li>
<li>kio/tests/fileundomanagertest.h <span style="color: grey">(ebd02fa)</span></li>
<li>kjsembed/kjsembed/slotproxy.cpp <span style="color: grey">(0c6c56c)</span></li>
<li>knewstuff/knewstuff3/core/provider.h <span style="color: grey">(a92d42d)</span></li>
<li>knewstuff/knewstuff3/ui/imagepreviewwidget.h <span style="color: grey">(f926084)</span></li>
<li>knewstuff/knewstuff3/ui/itemsviewbasedelegate.h <span style="color: grey">(543a749)</span></li>
<li>knewstuff/tests/knewstuff2_cache.h <span style="color: grey">(38e1b2f)</span></li>
<li>knewstuff/tests/knewstuff2_download.h <span style="color: grey">(d186872)</span></li>
<li>knewstuff/tests/knewstuff2_test.h <span style="color: grey">(853b66e)</span></li>
<li>knewstuff/tests/knewstuffauthortest.cpp <span style="color: grey">(96cf83f)</span></li>
<li>knewstuff/tests/knewstuffentrytest.cpp <span style="color: grey">(6be8e0a)</span></li>
<li>knewstuff/tests/testTranslatable.cpp <span style="color: grey">(debc328)</span></li>
<li>kparts/tests/parts.h <span style="color: grey">(5194c5d)</span></li>
<li>kross/modules/form.h <span style="color: grey">(081bfca)</span></li>
<li>kunitconversion/tests/categorytest.h <span style="color: grey">(3e74c1b)</span></li>
<li>kunitconversion/tests/convertertest.h <span style="color: grey">(99fe770)</span></li>
<li>kunitconversion/tests/valuetest.h <span style="color: grey">(b2c5086)</span></li>
<li>staging/itemviews/CMakeLists.txt <span style="color: grey">(71169639)</span></li>
<li>staging/itemviews/autotests/klistwidgetsearchlinetest.cpp <span style="color: grey">(10bb491)</span></li>
<li>staging/kde4attic/CMakeLists.txt <span style="color: grey">(990cf8f)</span></li>
<li>staging/kde4attic/src/kcupsoptionsjobwidget_p.h <span style="color: grey">(9302f20)</span></li>
<li>staging/kde4attic/src/kcupsoptionswidget_p.h <span style="color: grey">(fc5c9e1)</span></li>
<li>staging/kde4attic/src/kdatetimeedit.cpp <span style="color: grey">(17b8a7d)</span></li>
<li>staging/kde4attic/src/ktcpsocket.h <span style="color: grey">(eb782d0)</span></li>
<li>staging/kde4attic/tests/kanimatedbuttontest.h <span style="color: grey">(3e98d70)</span></li>
<li>staging/kde4support/CMakeLists.txt <span style="color: grey">(7f8700f)</span></li>
<li>staging/kde4support/autotests/kfadewidgeteffecttest.cpp <span style="color: grey">(a4ef0b8)</span></li>
<li>staging/kde4support/src/kdeui/kapplication.h <span style="color: grey">(62e98f9)</span></li>
<li>staging/kguiaddons/tests/kmodifierkeyinfotest.cpp <span style="color: grey">(981b153)</span></li>
<li>staging/ktextwidgets/src/kregexpeditor/kregexpeditorinterface.h <span style="color: grey">(4e8d73b)</span></li>
<li>staging/kwidgets/CMakeLists.txt <span style="color: grey">(32b4263)</span></li>
<li>tier1/kwindowsystem/src/kwindowsystem_mac.cpp <span style="color: grey">(4f7897e)</span></li>
<li>tier1/solid/CMakeLists.txt <span style="color: grey">(4940971)</span></li>
<li>tier1/solid/autotests/fakehardwaretest.h <span style="color: grey">(406f153)</span></li>
<li>tier1/solid/autotests/halbasictest.h <span style="color: grey">(82dd2c8)</span></li>
<li>tier1/solid/autotests/solidhwtest.h <span style="color: grey">(3b0b15e)</span></li>
<li>tier1/solid/autotests/solidmttest.cpp <span style="color: grey">(3298773)</span></li>
<li>tier1/solid/src/solid/backends/win/winacadapter.h <span style="color: grey">(15d334e)</span></li>
<li>tier1/solid/src/solid/backends/win/winbattery.h <span style="color: grey">(17ae47e)</span></li>
<li>tier1/solid/src/solid/backends/win/windevicemanager.h <span style="color: grey">(b2d3c40)</span></li>
<li>tier1/solid/src/solid/backends/win/wingenericinterface.h <span style="color: grey">(16fa0ce)</span></li>
<li>tier1/solid/src/solid/backends/win/winopticaldrive.h <span style="color: grey">(ce6c2c4)</span></li>
<li>tier1/solid/src/solid/backends/win/winstorageaccess.h <span style="color: grey">(10c92e8)</span></li>
<li>tier2/kauth/src/kauthactionreply.h <span style="color: grey">(9ed7860)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111609/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>