<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111491/">http://git.reviewboard.kde.org/r/111491/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit fa8d82a86fb1fc7999dce1e1c1dd6261dafbc23c by Benjamin Port to branch frameworks.</pre>
 <br />









<p>- Commit</p>


<br />
<p>On July 12th, 2013, 12:49 p.m. UTC, Benjamin Port wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Benjamin Port.</div>


<p style="color: grey;"><i>Updated July 12, 2013, 12:49 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order to have all frameworks using the same name policy (i.e. use CamelCase for libraries names) rename kde4support framework lib to KDE4Support</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(a03f33b)</span></li>

 <li>cmake/modules/FindKDE4Internal.cmake <span style="color: grey">(8786a9d)</span></li>

 <li>interfaces/kimproxy/library/CMakeLists.txt <span style="color: grey">(5bc4b4d)</span></li>

 <li>kdeui/tests/CMakeLists.txt <span style="color: grey">(b6d5b30)</span></li>

 <li>kdewidgets/CMakeLists.txt <span style="color: grey">(1f72c6f)</span></li>

 <li>khtml/java/CMakeLists.txt <span style="color: grey">(bb6ab56)</span></li>

 <li>khtml/java/tests/CMakeLists.txt <span style="color: grey">(55b38da)</span></li>

 <li>kinit/CMakeLists.txt <span style="color: grey">(656d2a7)</span></li>

 <li>kio/CMakeLists.txt <span style="color: grey">(c5cc280)</span></li>

 <li>kjsembed/kjscmd/CMakeLists.txt <span style="color: grey">(9ec86dc)</span></li>

 <li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(31e36e5)</span></li>

 <li>staging/kde4support/CMakeLists.txt <span style="color: grey">(b01602e)</span></li>

 <li>staging/kde4support/autotests/CMakeLists.txt <span style="color: grey">(0e674ac)</span></li>

 <li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(96ba1ad)</span></li>

 <li>staging/kde4support/tests/CMakeLists.txt <span style="color: grey">(4e228c3)</span></li>

 <li>staging/kwidgets/tests/CMakeLists.txt <span style="color: grey">(a847d08)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111491/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>